linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Wu <peter@lekensteyn.nl>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Rick Kerkhof <rick.2889@gmail.com>,
	linux-acpi@vger.kernel.org, nouveau@lists.freedesktop.org,
	linux-pci@vger.kernel.org
Subject: Re: Acer Aspire V7-582PG (Haswell, GTX 750M) fails to power off GPU via Power Resources
Date: Thu, 27 Oct 2016 18:06:48 +0200	[thread overview]
Message-ID: <20161027160648.GF27017@al> (raw)
In-Reply-To: <20161027095508.GA1476@lahna.fi.intel.com>

On Thu, Oct 27, 2016 at 12:55:08PM +0300, Mika Westerberg wrote:
> On Thu, Oct 27, 2016 at 09:42:28AM +0000, Rick Kerkhof wrote:
> >    No, there are not. Here is the recursive directory listing:
> 
> Are you able to try the following patch and send me dmesg (or attach it
> to that bug)? It should show if the ACPI core even tries to add those
> power resources.

So Rick has tested this patch now on top of 4.8.4 (mainline fails to
boot due to a kbuild issue which I reported elsewhere), but the output
is empty. That seems to indicate that flags.power_resources is unset.

Given that _PS3 exists and is indeed a package with some elements, it
seems that acpi_extract_power_resources is failing. Note that in the
SSDT, the power resource NVP3 was referenced before it was defined,
could that result in this enumeration failure? Relevant SSDT excerpt:

    Scope (\_SB.PCI0.RP05)
    {
        Name (_PR3, Package (0x01)  // _PR3: Power Resources for D3hot
        {
            NVP3
        })
        // ...
    }

    PowerResource (NVP3, 0x00, 0x0000)

Kind regards,
Peter

> diff --git a/drivers/acpi/power.c b/drivers/acpi/power.c
> index fcd4ce6f78d5..af9c3e15dd74 100644
> --- a/drivers/acpi/power.c
> +++ b/drivers/acpi/power.c
> @@ -444,6 +444,9 @@ void acpi_power_add_remove_device(struct acpi_device *adev, bool add)
>  	if (!adev->power.flags.power_resources)
>  		return;
>  
> +	acpi_handle_info(adev->handle, "Adding power resources for %s\n",
> +			 dev_name(&adev->dev));
> +
>  	for (state = ACPI_STATE_D0; state <= ACPI_STATE_D3_HOT; state++)
>  		acpi_power_expose_hide(adev,
>  				       &adev->power.states[state].resources,

  parent reply	other threads:[~2016-10-27 16:06 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-98398-8800@http.bugs.freedesktop.org/>
     [not found] ` <bug-98398-8800-66oU1nuK0R@http.bugs.freedesktop.org/>
2016-10-26 22:56   ` Acer Aspire V7-582PG (Haswell, GTX 750M) fails to power off GPU via Power Resources Peter Wu
2016-10-27  8:17     ` Mika Westerberg
2016-10-27  9:06       ` Peter Wu
     [not found]         ` <CANni8hdMs4pL0m6FrgeyJjE2R2C=6PaHbVbMVoUU+NszJuf9OA@mail.gmail.com>
2016-10-27  9:30           ` Mika Westerberg
2016-10-27  9:35             ` Peter Wu
     [not found]             ` <CANni8her35iORgrZOkDzxhfVaOOzObTLG2Ly0kkNZPDTrbyfQQ@mail.gmail.com>
2016-10-27  9:55               ` Mika Westerberg
     [not found]                 ` <CANni8hfSnT46pH8EnA1f00SWXUrJ=8PHRjydricGbH4AS4mR7A@mail.gmail.com>
2016-10-27 10:12                   ` Mika Westerberg
2016-10-27 16:06                 ` Peter Wu [this message]
2016-10-28  8:56                   ` Mika Westerberg
2016-10-28 11:09                     ` Peter Wu
2016-10-28 11:19                       ` Mika Westerberg
2016-10-28 12:30                         ` Peter Wu
2016-10-28 14:10                           ` Mika Westerberg
2016-10-29  0:49                             ` Zheng, Lv
2016-10-30 14:18                               ` Peter Wu
2016-10-29  0:42                     ` Zheng, Lv
2016-10-30 11:08                       ` Peter Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161027160648.GF27017@al \
    --to=peter@lekensteyn.nl \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=nouveau@lists.freedesktop.org \
    --cc=rick.2889@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).