linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Emil Velikov <emil.l.velikov@gmail.com>
To: dri-devel@lists.freedesktop.org
Cc: emil.l.velikov@gmail.com, "Jammy Zhou" <Jammy.Zhou@amd.com>,
	"Michel Dänzer" <michel.daenzer@amd.com>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] PCI: create revision file in sysfs
Date: Tue,  1 Nov 2016 15:42:32 +0000	[thread overview]
Message-ID: <20161101154232.6451-1-emil.l.velikov@gmail.com> (raw)

From: Emil Velikov <emil.velikov@collabora.com>

Currently the revision isn't available via sysfs/libudev thus if one
wants to know the value they need to read through the config file.

This in itself wakes/powers up the device, causing unwanted delay
since it can be quite costly.

Expose the revision as a separate file, just like we do for the device,
vendor, their subsystem version and class.

Cc: Jammy Zhou <Jammy.Zhou@amd.com>
Cc: Michel Dänzer <michel.daenzer@amd.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
---
Gents, I'm not subscribed to the mailing list so please keep me in the
CC chain.

Thanks
Emil
---
 drivers/pci/pci-sysfs.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
index bcd10c7..0666287 100644
--- a/drivers/pci/pci-sysfs.c
+++ b/drivers/pci/pci-sysfs.c
@@ -50,6 +50,7 @@ pci_config_attr(vendor, "0x%04x\n");
 pci_config_attr(device, "0x%04x\n");
 pci_config_attr(subsystem_vendor, "0x%04x\n");
 pci_config_attr(subsystem_device, "0x%04x\n");
+pci_config_attr(revision, "0x%02x\n");
 pci_config_attr(class, "0x%06x\n");
 pci_config_attr(irq, "%u\n");
 
@@ -568,6 +569,7 @@ static struct attribute *pci_dev_attrs[] = {
 	&dev_attr_device.attr,
 	&dev_attr_subsystem_vendor.attr,
 	&dev_attr_subsystem_device.attr,
+	&dev_attr_revision.attr,
 	&dev_attr_class.attr,
 	&dev_attr_irq.attr,
 	&dev_attr_local_cpus.attr,
-- 
2.9.3


             reply	other threads:[~2016-11-01 15:42 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-01 15:42 Emil Velikov [this message]
2016-11-01 15:47 ` [PATCH] PCI: create revision file in sysfs Alex Deucher
2016-11-08 11:27   ` Emil Velikov
2016-11-09 16:56 ` [PATCH v2] " Emil Velikov
2016-11-10  7:13   ` Greg KH
2016-11-10 13:14     ` Emil Velikov
2016-11-10 23:59       ` Bjorn Helgaas
2016-11-11  0:31         ` Emil Velikov
2016-11-11 14:49           ` Bjorn Helgaas
2016-11-11 18:56             ` Emil Velikov
2016-11-14 17:20               ` Bjorn Helgaas
2016-11-14  3:35         ` Michel Dänzer
2016-11-11 14:37 ` [PATCH v3] " Emil Velikov
2016-11-14 18:40   ` Daniel Vetter
2016-11-16 20:58     ` Bjorn Helgaas
2016-11-16 21:30       ` Sinan Kaya
2016-11-17 13:28       ` Alex Deucher
2016-11-17 14:35         ` Bjorn Helgaas
2016-11-17 14:48           ` Alex Deucher
2016-11-17 14:44       ` Lukas Wunner
2016-11-17 23:48         ` Bjorn Helgaas
2016-11-18  1:42           ` Michel Dänzer
2016-11-18  2:40             ` Bjorn Helgaas
2016-11-18  9:42               ` Daniel Vetter
2016-11-18  9:48                 ` Daniel Vetter
2016-11-18 14:29                   ` Bjorn Helgaas
2016-11-18 15:04                   ` Alex Deucher
2016-11-18 19:06   ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161101154232.6451-1-emil.l.velikov@gmail.com \
    --to=emil.l.velikov@gmail.com \
    --cc=Jammy.Zhou@amd.com \
    --cc=bhelgaas@google.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=michel.daenzer@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).