From: Christoph Hellwig <hch@lst.de>
To: Jan Beulich <JBeulich@suse.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
tglx@linutronix.de, hch@lst.de, linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI/MSI: pci_irq_get_affinity() should cope with NULL affinity vector
Date: Tue, 8 Nov 2016 15:59:43 +0100 [thread overview]
Message-ID: <20161108145943.GD12817@lst.de> (raw)
In-Reply-To: <5821904A020000780011CF55@prv-mh.provo.novell.com>
On Tue, Nov 08, 2016 at 12:43:54AM -0700, Jan Beulich wrote:
> msi_setup_entry() only logs a message when the affinity vector can't be
> allocated, and hence pci_irq_get_affinity() indexing entry->affinity is
> wrong without a prior check.
Looks fine:
Reviewed-by: Christoph Hellwig <hch@lst.de>
But just curious: did you run into that case in practice?
next prev parent reply other threads:[~2016-11-08 14:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-08 7:43 [PATCH] PCI/MSI: pci_irq_get_affinity() should cope with NULL affinity vector Jan Beulich
2016-11-08 14:59 ` Christoph Hellwig [this message]
2016-11-08 15:15 ` Jan Beulich
2016-11-08 21:53 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161108145943.GD12817@lst.de \
--to=hch@lst.de \
--cc=JBeulich@suse.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox