From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:39086 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755537AbcKJLdY (ORCPT ); Thu, 10 Nov 2016 06:33:24 -0500 Date: Thu, 10 Nov 2016 08:13:27 +0100 From: Greg KH To: Emil Velikov Cc: dri-devel@lists.freedesktop.org, Bjorn Helgaas , linux-pci@vger.kernel.org Subject: Re: [PATCH v2] PCI: create revision file in sysfs Message-ID: <20161110071327.GA30661@kroah.com> References: <20161101154232.6451-1-emil.l.velikov@gmail.com> <20161109165607.26322-1-emil.l.velikov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20161109165607.26322-1-emil.l.velikov@gmail.com> Sender: linux-pci-owner@vger.kernel.org List-ID: On Wed, Nov 09, 2016 at 04:56:07PM +0000, Emil Velikov wrote: > From: Emil Velikov > > Currently the revision isn't available via sysfs/libudev thus if one > wants to know the value they need to read through the config file. > > This in itself wakes/powers up the device, causing unwanted delays. > > There are at least two userspace components which could make use the new > file - libpciaccess and libdrm. At the moment the former will wake up > _every_ PCI device for simple invocation of glxinfo [when using Mesa > 10.0+ drivers]. While the latter [in association with Mesa 13.0] can > lead to 2-3 second delays while starting firefox, thunderbird or > chromium. > > Expose the revision as a separate file, just like we do for the device, > vendor, their subsystem version and class. > > Cc: Bjorn Helgaas > Cc: linux-pci@vger.kernel.org > Link: https://bugs.freedesktop.org/show_bug.cgi?id=98502 > Tested-by: Mauro Santos > Reviewed-by: Alex Deucher > Signed-off-by: Emil Velikov > --- > v2: > - Add r-b/t-b tags > - Slim down CC list > - Add note about userspace. > > As before, please keep me in the CC list. Additionally if there's > anything else I can do to get things going please let me know. > > Thanks > Emil > --- > drivers/pci/pci-sysfs.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c > index bcd10c7..0666287 100644 > --- a/drivers/pci/pci-sysfs.c > +++ b/drivers/pci/pci-sysfs.c > @@ -50,6 +50,7 @@ pci_config_attr(vendor, "0x%04x\n"); > pci_config_attr(device, "0x%04x\n"); > pci_config_attr(subsystem_vendor, "0x%04x\n"); > pci_config_attr(subsystem_device, "0x%04x\n"); > +pci_config_attr(revision, "0x%02x\n"); > pci_config_attr(class, "0x%06x\n"); > pci_config_attr(irq, "%u\n"); Shouldn't we get a Documentation/ABI/ update for this as well? thanks, greg k-h