From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Date: Fri, 18 Nov 2016 16:00:06 +0000 From: Will Deacon To: Lorenzo Pieralisi Subject: Re: [PATCH v8 12/16] drivers: iommu: arm-smmu: split probe functions into DT/generic portions Message-ID: <20161118160006.GW13470@arm.com> References: <20161116152936.22955-1-lorenzo.pieralisi@arm.com> <20161116152936.22955-13-lorenzo.pieralisi@arm.com> MIME-Version: 1.0 In-Reply-To: <20161116152936.22955-13-lorenzo.pieralisi@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, Marc Zyngier , Tomasz Nowicki , Joerg Roedel , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Sinan Kaya , Eric Auger , iommu@lists.linux-foundation.org, Hanjun Guo , Jon Masters , Dennis Chen , Prem Mallappa , Robin Murphy , Nate Watterson Content-Type: text/plain; charset="us-ascii" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+bjorn=helgaas.com@lists.infradead.org List-ID: On Wed, Nov 16, 2016 at 03:29:32PM +0000, Lorenzo Pieralisi wrote: > Current ARM SMMU probe functions intermingle HW and DT probing > in the initialization functions to detect and programme the ARM SMMU > driver features. In order to allow probing the ARM SMMU with other > firmwares than DT, this patch splits the ARM SMMU init functions into > DT and HW specific portions so that other FW interfaces (ie ACPI) can > reuse the HW probing functions and skip the DT portion accordingly. > > This patch implements no functional change, only code reshuffling. > > Signed-off-by: Lorenzo Pieralisi > Reviewed-by: Tomasz Nowicki > Tested-by: Hanjun Guo > Tested-by: Tomasz Nowicki > Cc: Will Deacon > Cc: Hanjun Guo > Cc: Robin Murphy > --- > drivers/iommu/arm-smmu.c | 62 +++++++++++++++++++++++++++++------------------- > 1 file changed, 37 insertions(+), 25 deletions(-) Reviewed-by: Will Deacon Although I'd also like Robin to have a look at this. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel