* [PATCH] drivers/pci/host/vmd: Fix suspend handlers unused warning
@ 2016-11-26 18:29 Borislav Petkov
2016-11-28 16:30 ` Keith Busch
2016-12-07 18:17 ` Bjorn Helgaas
0 siblings, 2 replies; 3+ messages in thread
From: Borislav Petkov @ 2016-11-26 18:29 UTC (permalink / raw)
To: LKML; +Cc: Keith Busch, Bjorn Helgaas, linux-pci
From: Borislav Petkov <bp@suse.de>
Fix:
drivers/pci/host/vmd.c:731:12: warning: ‘vmd_suspend’ defined but not used [-Wunused-function]
static int vmd_suspend(struct device *dev)
^
drivers/pci/host/vmd.c:739:12: warning: ‘vmd_resume’ defined but not used [-Wunused-function]
static int vmd_resume(struct device *dev)
^
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Keith Busch <keith.busch@intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org
---
drivers/pci/host/vmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/host/vmd.c b/drivers/pci/host/vmd.c
index 37e29b580be3..0e7f8f319fe3 100644
--- a/drivers/pci/host/vmd.c
+++ b/drivers/pci/host/vmd.c
@@ -727,7 +727,7 @@ static void vmd_remove(struct pci_dev *dev)
irq_domain_remove(vmd->irq_domain);
}
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_SLEEP
static int vmd_suspend(struct device *dev)
{
struct pci_dev *pdev = to_pci_dev(dev);
--
2.10.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/pci/host/vmd: Fix suspend handlers unused warning
2016-11-26 18:29 [PATCH] drivers/pci/host/vmd: Fix suspend handlers unused warning Borislav Petkov
@ 2016-11-28 16:30 ` Keith Busch
2016-12-07 18:17 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Keith Busch @ 2016-11-28 16:30 UTC (permalink / raw)
To: Borislav Petkov; +Cc: LKML, Bjorn Helgaas, linux-pci
On Sat, Nov 26, 2016 at 07:29:57PM +0100, Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
>
> Fix:
>
> drivers/pci/host/vmd.c:731:12: warning: ‘vmd_suspend’ defined but not used [-Wunused-function]
> static int vmd_suspend(struct device *dev)
> ^
> drivers/pci/host/vmd.c:739:12: warning: ‘vmd_resume’ defined but not used [-Wunused-function]
> static int vmd_resume(struct device *dev)
> ^
>
> Signed-off-by: Borislav Petkov <bp@suse.de>
Thanks for the fix.
Reviewed-by: Keith Busch <keith.busch@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/pci/host/vmd: Fix suspend handlers unused warning
2016-11-26 18:29 [PATCH] drivers/pci/host/vmd: Fix suspend handlers unused warning Borislav Petkov
2016-11-28 16:30 ` Keith Busch
@ 2016-12-07 18:17 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2016-12-07 18:17 UTC (permalink / raw)
To: Borislav Petkov; +Cc: LKML, Keith Busch, Bjorn Helgaas, linux-pci
On Sat, Nov 26, 2016 at 07:29:57PM +0100, Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
>
> Fix:
>
> drivers/pci/host/vmd.c:731:12: warning: ‘vmd_suspend’ defined but not used [-Wunused-function]
> static int vmd_suspend(struct device *dev)
> ^
> drivers/pci/host/vmd.c:739:12: warning: ‘vmd_resume’ defined but not used [-Wunused-function]
> static int vmd_resume(struct device *dev)
> ^
>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Cc: Keith Busch <keith.busch@intel.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: linux-pci@vger.kernel.org
Applied with Keith's reviewed-by to pci/host-vmd for v4.10, thanks!
> ---
> drivers/pci/host/vmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/vmd.c b/drivers/pci/host/vmd.c
> index 37e29b580be3..0e7f8f319fe3 100644
> --- a/drivers/pci/host/vmd.c
> +++ b/drivers/pci/host/vmd.c
> @@ -727,7 +727,7 @@ static void vmd_remove(struct pci_dev *dev)
> irq_domain_remove(vmd->irq_domain);
> }
>
> -#ifdef CONFIG_PM
> +#ifdef CONFIG_PM_SLEEP
> static int vmd_suspend(struct device *dev)
> {
> struct pci_dev *pdev = to_pci_dev(dev);
> --
> 2.10.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-12-07 18:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-26 18:29 [PATCH] drivers/pci/host/vmd: Fix suspend handlers unused warning Borislav Petkov
2016-11-28 16:30 ` Keith Busch
2016-12-07 18:17 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).