linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Tadeusz Struk <tadeusz.struk@intel.com>
Cc: dledford@redhat.com, linux-rdma@vger.kernel.org,
	linux-pci@vger.kernel.org, dennis.dalessandro@intel.com,
	ira.weiny@intel.com
Subject: Re: [PATCH] [RFC] IB/hfi1: Fix port ordering issue in a multiport device
Date: Wed, 11 Jan 2017 11:10:42 -0700	[thread overview]
Message-ID: <20170111181042.GC22783@obsidianresearch.com> (raw)
In-Reply-To: <148409267200.13402.16060755922068447437.stgit@tstruk-mobl1.ra.intel.com>

On Tue, Jan 10, 2017 at 03:57:52PM -0800, Tadeusz Struk wrote:
> We can fix this by enforcing the correct port order at module load time.
> To reorder the ports to match the numbering labels on the back of the
> device we need to delay registering devices with the ib_core until
> we

Sorry, no way - this is horrifying.

If you need stable names for RDMA devices then you need to add proper
infrastructure to the kernel to rename RDMA devices from user space
via udev. ala netdev.

or change the ib_core to allow your driver to specify the full name
and manage things in your driver.

No way on this insane block probe approach.

Jason

  parent reply	other threads:[~2017-01-11 18:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-10 23:57 [PATCH] [RFC] IB/hfi1: Fix port ordering issue in a multiport device Tadeusz Struk
2017-01-11  7:12 ` Leon Romanovsky
2017-01-11 17:20   ` Tadeusz Struk
2017-01-11 17:59     ` Leon Romanovsky
2017-01-11 18:10 ` Jason Gunthorpe [this message]
2017-01-18 21:01   ` Doug Ledford
2017-01-18 21:08     ` Jason Gunthorpe
2017-01-18 22:03       ` Tadeusz Struk
2017-01-19  0:17         ` Doug Ledford
2017-01-19 16:51           ` Tadeusz Struk
2017-01-19  0:16       ` Doug Ledford
2017-01-19 17:58         ` Jason Gunthorpe
2017-01-22  8:16           ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170111181042.GC22783@obsidianresearch.com \
    --to=jgunthorpe@obsidianresearch.com \
    --cc=dennis.dalessandro@intel.com \
    --cc=dledford@redhat.com \
    --cc=ira.weiny@intel.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=tadeusz.struk@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).