From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Doug Ledford <dledford@redhat.com>
Cc: Tadeusz Struk <tadeusz.struk@intel.com>,
linux-rdma@vger.kernel.org, linux-pci@vger.kernel.org,
dennis.dalessandro@intel.com, ira.weiny@intel.com
Subject: Re: [PATCH] [RFC] IB/hfi1: Fix port ordering issue in a multiport device
Date: Wed, 18 Jan 2017 14:08:31 -0700 [thread overview]
Message-ID: <20170118210831.GA7590@obsidianresearch.com> (raw)
In-Reply-To: <1484773260.2406.58.camel@redhat.com>
On Wed, Jan 18, 2017 at 04:01:00PM -0500, Doug Ledford wrote:
> OK, sure, as far as the reordering stuff is concerned, all you need to
> do is to make use of the EPROBE_DEFER return option to your PCI probe
> routine. That way, when you get the probe for the out of order
> port,
EPROBE_DEFER is intended when waiting on other components the driver
may need, not for setting stable names.
This is a 'stable device naming' problem, which we have never tried to
solve in RDMA.
udev is the expected kernel way to solve this. Trying to hack stable
names by forcing device bind order is horrible.
hfi runs smack into this because it is the first scheme to actually
typically operate in a multi-struct ib_device world, which means they
get to solve it properly :\
Jason
next prev parent reply other threads:[~2017-01-18 21:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 23:57 [PATCH] [RFC] IB/hfi1: Fix port ordering issue in a multiport device Tadeusz Struk
2017-01-11 7:12 ` Leon Romanovsky
2017-01-11 17:20 ` Tadeusz Struk
2017-01-11 17:59 ` Leon Romanovsky
2017-01-11 18:10 ` Jason Gunthorpe
2017-01-18 21:01 ` Doug Ledford
2017-01-18 21:08 ` Jason Gunthorpe [this message]
2017-01-18 22:03 ` Tadeusz Struk
2017-01-19 0:17 ` Doug Ledford
2017-01-19 16:51 ` Tadeusz Struk
2017-01-19 0:16 ` Doug Ledford
2017-01-19 17:58 ` Jason Gunthorpe
2017-01-22 8:16 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170118210831.GA7590@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=dennis.dalessandro@intel.com \
--cc=dledford@redhat.com \
--cc=ira.weiny@intel.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=tadeusz.struk@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).