From: Phil Sutter <phil@nwl.cc>
To: David Miller <davem@davemloft.net>
Cc: bhelgaas@google.com, netdev@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [net-next PATCH 0/3] Retrieve number of VFs in a bus-agnostic way
Date: Fri, 20 Jan 2017 17:59:14 +0100 [thread overview]
Message-ID: <20170120165914.GF5197@orbyte.nwl.cc> (raw)
In-Reply-To: <20170120.114346.786441265338417344.davem@davemloft.net>
On Fri, Jan 20, 2017 at 11:43:46AM -0500, David Miller wrote:
> From: Phil Sutter <phil@nwl.cc>
> Date: Wed, 18 Jan 2017 14:04:36 +0100
>
> > Previously, it was assumed that only PCI NICs would be capable of having
> > virtual functions - with my proposed enhancement of dummy NIC driver
> > implementing (fake) ones for testing purposes, this is no longer true.
> >
> > Discussion of said patch has led to the suggestion of implementing a
> > bus-agnostic method for VF count retrieval so rtnetlink could work with
> > both real VF-capable PCI NICs as well as my dummy modifications without
> > introducing ugly hacks.
> >
> > The following series tries to achieve just that by introducing a bus
> > type callback to retrieve a device's number of VFs, implementing this
> > callback for PCI bus and finally adjusting rtnetlink to make use of the
> > generalized infrastructure.
>
> This is really nice and clean, compare it to your original approach :-)
Yes, indeed! Thanks a lot for pointing me into the right direction. :)
Cheers, Phil
prev parent reply other threads:[~2017-01-20 16:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 13:04 [net-next PATCH 0/3] Retrieve number of VFs in a bus-agnostic way Phil Sutter
2017-01-18 13:04 ` [net-next PATCH 1/3] device: bus_type: Introduce num_vf callback Phil Sutter
2017-01-18 13:04 ` [net-next PATCH 2/3] PCI: implement num_vf bus type callback Phil Sutter
2017-01-18 13:04 ` [net-next PATCH 3/3] device: Implement a bus agnostic dev_num_vf routine Phil Sutter
2017-01-20 16:43 ` [net-next PATCH 0/3] Retrieve number of VFs in a bus-agnostic way David Miller
2017-01-20 16:59 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170120165914.GF5197@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).