From: Christoph Hellwig <hch@lst.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
bhelgaas@google.com, bart.vanassche@sandisk.com,
tglx@linutronix.de, linux-pci@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] PCI/MSI: don't apply affinity if there aren't enough vectors left
Date: Thu, 2 Feb 2017 19:32:16 +0100 [thread overview]
Message-ID: <20170202183216.GA8385@lst.de> (raw)
In-Reply-To: <20170202173659.GD21267@bhelgaas-glaptop.roam.corp.google.com>
On Thu, Feb 02, 2017 at 11:36:59AM -0600, Bjorn Helgaas wrote:
> You didn't say exactly where the out of bounds access was, but I assume
> it's probably in irq_create_affinity_masks() in this path:
Yes. See the original report from Bart here:
http://www.spinics.net/lists/linux-scsi/msg104082.html
> The fix in pci_alloc_irq_vectors_affinity() looks fine, but I wish it
> were closer to the actual problem.
I plan to also fix the low-level issue, but:
a) I have other patches pending in that are for 4.11 and I'd like
to batch them up with those to avoid conflicts
b) we really need a high-level check like the one added in this
patch so that we do the right thing (drop affinity) in this
case instead of returning an error to the caller and failing
the probe.
next prev parent reply other threads:[~2017-02-02 18:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-30 12:15 [PATCH] PCI/MSI: don't apply affinity if there aren't enough vectors left Christoph Hellwig
2017-02-02 17:36 ` Bjorn Helgaas
2017-02-02 18:32 ` Christoph Hellwig [this message]
2017-02-02 22:38 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170202183216.GA8385@lst.de \
--to=hch@lst.de \
--cc=bart.vanassche@sandisk.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).