From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Keith Busch <keith.busch@intel.com>,
linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
Lukas Wunner <lukas@wunner.de>, Wei Zhang <wzhang@fb.com>,
Austin Bolen <Austin.Bolen@dell.com>
Subject: Re: [PATCHv5 2/5] pci: Add device disconnected state
Date: Mon, 6 Feb 2017 18:40:46 +0100 [thread overview]
Message-ID: <20170206174046.GA10441@kroah.com> (raw)
In-Reply-To: <20170206173202.GB25762@infradead.org>
On Mon, Feb 06, 2017 at 09:32:02AM -0800, Christoph Hellwig wrote:
> On Fri, Feb 03, 2017 at 09:53:30PM +0100, Greg Kroah-Hartman wrote:
> > > +/* pci_dev priv_flags */
> > > +#define PCI_DEV_DISCONNECTED 0
> > > +
> > > +static inline int pci_dev_set_disconnected(struct pci_dev *dev, void *unused)
> > > +{
> > > + set_bit(PCI_DEV_DISCONNECTED, &dev->priv_flags);
> >
> > Why a single bit? Are you trying to do this without locking or
> > something? And if you want a bit, what's wrong with a C bit type? Or
> > just a boolean?
>
> What's a C bit type?
Sorry, was thinking of:
unsigned foo:2;
don't know what the "real" name for that is...
thanks,
greg k-h
next prev parent reply other threads:[~2017-02-06 17:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 17:55 [PATCHv5 0/5] Limiting PCI access Keith Busch
2017-02-03 17:55 ` [PATCHv5 1/5] pci: Export pci device config accessors Keith Busch
2017-02-06 17:30 ` Christoph Hellwig
2017-02-03 17:55 ` [PATCHv5 2/5] pci: Add device disconnected state Keith Busch
2017-02-03 20:53 ` Greg Kroah-Hartman
2017-02-06 17:32 ` Christoph Hellwig
2017-02-06 17:40 ` Greg Kroah-Hartman [this message]
2017-02-06 17:48 ` Christoph Hellwig
2017-02-06 17:54 ` Keith Busch
2017-02-06 17:33 ` Christoph Hellwig
2017-02-06 21:11 ` Keith Busch
2017-02-03 17:55 ` [PATCHv5 3/5] pci: No config access for disconnected devices Keith Busch
2017-02-06 17:34 ` Christoph Hellwig
2017-02-03 17:55 ` [PATCHv5 4/5] pci/msix: Skip disabling " Keith Busch
2017-02-06 17:35 ` Christoph Hellwig
2017-02-03 17:55 ` [PATCHv5 5/5] pci: Quick return for pci_device_is_present Keith Busch
2017-02-06 17:36 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170206174046.GA10441@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Austin.Bolen@dell.com \
--cc=bhelgaas@google.com \
--cc=hch@infradead.org \
--cc=keith.busch@intel.com \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=wzhang@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).