linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: linux-pci@vger.kernel.org
Cc: "Rob Herring" <robh@kernel.org>,
	"Haiyang Zhang" <haiyangz@microsoft.com>,
	"Michal Simek" <michal.simek@xilinx.com>,
	"Jon Mason" <jon.mason@broadcom.com>,
	"Ray Jui" <ray.jui@broadcom.com>,
	linux-arm-kernel@lists.infradead.org,
	devel@linuxdriverproject.org,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
	"Tanmay Inamdar" <tinamdar@apm.com>
Subject: [PATCH v1 0/3] PCI: Configure PCIe MPS settings
Date: Wed, 08 Feb 2017 16:49:22 -0600	[thread overview]
Message-ID: <20170208224632.14351.89895.stgit@bhelgaas-glaptop.roam.corp.google.com> (raw)

[Some of you will get this twice because Gmail and I aren't getting along
today; sorry]

The PCI core doesn't configure the PCIe MPS settings by itself.  Each
host bridge driver has to call pcie_bus_configure_settings() to make
this happen.

Jon fixed this already for pcie-iproc.c.  I propose these similar
patches for other drivers.

HV guys, I included you because create_root_hv_pci_bus() is one place
that calls pci_scan_child_bus() but does not call
pcie_bus_configure_settings().  I know you probably don't strictly
*need* to configure MPS settings in a paravirtual front-end, but the
PCI core does other device configuration in this path:

  pci_scan_child_bus
    pci_scan_slot
      pci_scan_single_device
        pci_device_add
          pci_configure_device
          pci_init_capabilities

and I would like to eventually migrate the MPS configuration into that
same path.  Since we do this other configuration for HV devices
already, I think pcie_bus_configure_settings() should also work (even
if it ends up not doing anything to real devices).

It would make that eventual migration easier if all the
pci_scan_child_bus() callers had the same pattern of calling
pcie_bus_configure_settings().

So would it make sense to make a similar patch for HV?  It looks easy
to add it to create_root_hv_pci_bus(), but I don't know exactly what
to do about pci_devices_present_work().

---

Bjorn Helgaas (3):
      PCI: xilinx: Configure PCIe MPS settings
      PCI: versatile: Configure PCIe MPS settings
      PCI: xgene: Configure PCIe MPS settings


 drivers/pci/host/pci-versatile.c |    4 +++-
 drivers/pci/host/pci-xgene.c     |    4 +++-
 drivers/pci/host/pcie-xilinx.c   |    4 +++-
 3 files changed, 9 insertions(+), 3 deletions(-)

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

             reply	other threads:[~2017-02-08 22:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-08 22:49 Bjorn Helgaas [this message]
2017-02-08 22:49 ` [PATCH v1 1/3] PCI: xilinx: Configure PCIe MPS settings Bjorn Helgaas
2017-02-09  7:19   ` Christoph Hellwig
2017-02-10 21:58     ` Bjorn Helgaas
2017-02-08 22:49 ` [PATCH v1 2/3] PCI: versatile: " Bjorn Helgaas
2017-02-08 22:49 ` [PATCH v1 3/3] PCI: xgene: " Bjorn Helgaas
2017-02-10 21:59 ` [PATCH v1 0/3] PCI: " Bjorn Helgaas
2017-02-24 11:16   ` Dexuan Cui
2017-02-24 14:32     ` Bjorn Helgaas
  -- strict thread matches above, loose matches on Subject: below --
2017-02-08 22:08 Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170208224632.14351.89895.stgit@bhelgaas-glaptop.roam.corp.google.com \
    --to=helgaas@kernel.org \
    --cc=devel@linuxdriverproject.org \
    --cc=haiyangz@microsoft.com \
    --cc=jon.mason@broadcom.com \
    --cc=kys@microsoft.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=ray.jui@broadcom.com \
    --cc=robh@kernel.org \
    --cc=soren.brinkmann@xilinx.com \
    --cc=tinamdar@apm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).