linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org, "Rob Herring" <robh@kernel.org>,
	"Haiyang Zhang" <haiyangz@microsoft.com>,
	"Michal Simek" <michal.simek@xilinx.com>,
	"Jon Mason" <jon.mason@broadcom.com>,
	"Ray Jui" <ray.jui@broadcom.com>,
	"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
	devel@linuxdriverproject.org,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	linux-arm-kernel@lists.infradead.org,
	"Tanmay Inamdar" <tinamdar@apm.com>
Subject: Re: [PATCH v1 1/3] PCI: xilinx: Configure PCIe MPS settings
Date: Wed, 8 Feb 2017 23:19:56 -0800	[thread overview]
Message-ID: <20170209071956.GA21656@infradead.org> (raw)
In-Reply-To: <20170208224930.14351.91597.stgit@bhelgaas-glaptop.roam.corp.google.com>

On Wed, Feb 08, 2017 at 04:49:30PM -0600, Bjorn Helgaas wrote:
> +	list_for_each_entry(child, &bus->children, node)
> +		pcie_bus_configure_settings(child);

This loop is duplicated in just about every driver, so it it
might be a good idea to provide a littler helper for it.

  reply	other threads:[~2017-02-09  7:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-08 22:49 [PATCH v1 0/3] PCI: Configure PCIe MPS settings Bjorn Helgaas
2017-02-08 22:49 ` [PATCH v1 1/3] PCI: xilinx: " Bjorn Helgaas
2017-02-09  7:19   ` Christoph Hellwig [this message]
2017-02-10 21:58     ` Bjorn Helgaas
2017-02-08 22:49 ` [PATCH v1 2/3] PCI: versatile: " Bjorn Helgaas
2017-02-08 22:49 ` [PATCH v1 3/3] PCI: xgene: " Bjorn Helgaas
2017-02-10 21:59 ` [PATCH v1 0/3] PCI: " Bjorn Helgaas
2017-02-24 11:16   ` Dexuan Cui
2017-02-24 14:32     ` Bjorn Helgaas
  -- strict thread matches above, loose matches on Subject: below --
2017-02-08 22:08 Bjorn Helgaas
2017-02-08 22:08 ` [PATCH v1 1/3] PCI: xilinx: " Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170209071956.GA21656@infradead.org \
    --to=hch@infradead.org \
    --cc=devel@linuxdriverproject.org \
    --cc=haiyangz@microsoft.com \
    --cc=helgaas@kernel.org \
    --cc=jon.mason@broadcom.com \
    --cc=kys@microsoft.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=ray.jui@broadcom.com \
    --cc=robh@kernel.org \
    --cc=soren.brinkmann@xilinx.com \
    --cc=tinamdar@apm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).