From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Stephen Boyd <stephen.boyd@linaro.org>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] PCI: aardvark: Remove msi-controller dt node probing
Date: Tue, 14 Mar 2017 21:27:13 +0100 [thread overview]
Message-ID: <20170314212713.1afb7a9f@free-electrons.com> (raw)
In-Reply-To: <20170314193005.GC26264@bhelgaas-glaptop.roam.corp.google.com>
Hello,
On Tue, 14 Mar 2017 14:30:05 -0500, Bjorn Helgaas wrote:
> On Tue, Mar 14, 2017 at 12:08:51PM -0700, Stephen Boyd wrote:
> > This code assigns variables that are never used. Remove them.
> >
> > Reported-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> > Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org>
>
> I love removing unused code! Applied to pci/host-aardvark for v4.12,
> thanks!
Why? I have already sent a patch that also does this (and much more!) a
number of times already, and it has never been applied. See:
[PATCH v3 1/3] pci: pci-aardvark: move to MSI handling using generic MSI support
v1 on September 1st, 2016
v2 on December 23th, 2016
v3 on February 28th, 2017
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2017-03-14 20:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-14 19:08 [PATCH] PCI: aardvark: Remove msi-controller dt node probing Stephen Boyd
2017-03-14 19:30 ` Bjorn Helgaas
2017-03-14 20:17 ` Bjorn Helgaas
2017-03-14 20:27 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170314212713.1afb7a9f@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=stephen.boyd@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).