From: Gavin Shan <gwshan@linux.vnet.ibm.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: bodong@mellanox.com, helgaas@kernel.org,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
saeedm@mellanox.com, Eli Cohen <eli@mellanox.com>,
gwshan@linux.vnet.ibm.com
Subject: Re: [v3] PCI: Add an option to control probing of VFs before enabling SR-IOV
Date: Thu, 13 Apr 2017 15:24:50 +1000 [thread overview]
Message-ID: <20170413052450.GA32407@gwshan> (raw)
In-Reply-To: <20170412205614.429db99c@t450s.home>
On Wed, Apr 12, 2017 at 08:56:14PM -0600, Alex Williamson wrote:
>On Thu, 13 Apr 2017 01:51:40 +0300
>bodong@mellanox.com wrote:
>
>> From: Bodong Wang <bodong@mellanox.com>
>>
>> Sometimes it is not desirable to probe the virtual functions after
>> SRIOV is enabled. This can save host side resource usage by VF
>> instances which would be eventually probed to VMs.
>>
>> Add a new PCI sysfs interface "sriov_drivers_autoprobe" to control
>> that from the PF, all current callers still retain the same
>> functionality. To modify it, echo 0/n/N (disable probe) or 1/y/Y
>> (enable probe) to:
>>
>> /sys/bus/pci/devices/<DOMAIN:BUS:DEVICE.FUNCTION>/sriov_drivers_autoprobe
>>
>> Note that, the choice must be made before enabling VFs. The change
>> will not take effect if VFs are already enabled. Simply, one can set
>> sriov_numvfs to 0, choose whether to probe or not, and then resume
>> sriov_numvfs.
>>
>> Signed-off-by: Bodong Wang <bodong@mellanox.com>
>> Signed-off-by: Eli Cohen <eli@mellanox.com>
>> Reviewed-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
>> Reviewed-by: Alex Williamson <alex.williamson@redhat.com>
>
>Whoa, I reviewed the last version, that's different than providing a
>Reviewed-by, and I've certainly never seen this version until now, so I
>can't possibly have endorsed it in any way. It's also changed since
>Gavin saw it and I think Bjorn is in the same boat. Probably a good
>idea to cc the people you're claiming reviewed this too (cc +Gavin).
>
Thanks, Alex. I usually keep an eye on the patches that I ever
reviewed and follow them until they are merged or rejected. More
comments would be given if I have. Otherwise, everthing is fine.
Yes, it's always nice to copy those who reviewed the patch.
For this one, my reviewed-by is still valid.
Thanks,
Gavin
next prev parent reply other threads:[~2017-04-13 5:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-12 22:51 [v3] PCI: Add an option to control probing of VFs before enabling SR-IOV bodong
2017-04-13 2:56 ` Alex Williamson
2017-04-13 5:24 ` Gavin Shan [this message]
2017-04-13 14:16 ` Bodong Wang
2017-04-14 15:37 ` Bjorn Helgaas
2017-04-14 15:44 ` Bodong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170413052450.GA32407@gwshan \
--to=gwshan@linux.vnet.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=bodong@mellanox.com \
--cc=eli@mellanox.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox