* [PATCH v2] PCI: Make PCI_ROM_ADDRESS_MASK a 32-bit constant
@ 2017-04-11 17:56 Matthias Kaehlcke
2017-04-14 15:43 ` Bjorn Helgaas
0 siblings, 1 reply; 3+ messages in thread
From: Matthias Kaehlcke @ 2017-04-11 17:56 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: linux-pci, linux-kernel, Mason, Grant Grundler, Greg Hackmann,
Michael Davidson, Matthias Kaehlcke
A 64-bit value is not needed since a PCI ROM address consists in 32 bits.
This fixes a clang warning about "implicit conversion from 'unsigned
long' to 'u32'".
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
Changes in v2:
- Define PCI_ROM_ADDRESS_MASK as a 32-bit constant instead of using a cast
- Updated commit message
include/uapi/linux/pci_regs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/pci_regs.h b/include/uapi/linux/pci_regs.h
index 634c9c44ed6c..fff521c9458c 100644
--- a/include/uapi/linux/pci_regs.h
+++ b/include/uapi/linux/pci_regs.h
@@ -114,7 +114,7 @@
#define PCI_SUBSYSTEM_ID 0x2e
#define PCI_ROM_ADDRESS 0x30 /* Bits 31..11 are address, 10..1 reserved */
#define PCI_ROM_ADDRESS_ENABLE 0x01
-#define PCI_ROM_ADDRESS_MASK (~0x7ffUL)
+#define PCI_ROM_ADDRESS_MASK (~0x7ffU)
#define PCI_CAPABILITY_LIST 0x34 /* Offset of first capability list entry */
--
2.12.2.715.g7642488e1d-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] PCI: Make PCI_ROM_ADDRESS_MASK a 32-bit constant
2017-04-11 17:56 [PATCH v2] PCI: Make PCI_ROM_ADDRESS_MASK a 32-bit constant Matthias Kaehlcke
@ 2017-04-14 15:43 ` Bjorn Helgaas
2017-04-14 19:36 ` Matthias Kaehlcke
0 siblings, 1 reply; 3+ messages in thread
From: Bjorn Helgaas @ 2017-04-14 15:43 UTC (permalink / raw)
To: Matthias Kaehlcke
Cc: Bjorn Helgaas, linux-pci, linux-kernel, Mason, Grant Grundler,
Greg Hackmann, Michael Davidson
On Tue, Apr 11, 2017 at 10:56:58AM -0700, Matthias Kaehlcke wrote:
> A 64-bit value is not needed since a PCI ROM address consists in 32 bits.
> This fixes a clang warning about "implicit conversion from 'unsigned
> long' to 'u32'".
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> Changes in v2:
> - Define PCI_ROM_ADDRESS_MASK as a 32-bit constant instead of using a cast
> - Updated commit message
>
> include/uapi/linux/pci_regs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/pci_regs.h b/include/uapi/linux/pci_regs.h
> index 634c9c44ed6c..fff521c9458c 100644
> --- a/include/uapi/linux/pci_regs.h
> +++ b/include/uapi/linux/pci_regs.h
> @@ -114,7 +114,7 @@
> #define PCI_SUBSYSTEM_ID 0x2e
> #define PCI_ROM_ADDRESS 0x30 /* Bits 31..11 are address, 10..1 reserved */
> #define PCI_ROM_ADDRESS_ENABLE 0x01
> -#define PCI_ROM_ADDRESS_MASK (~0x7ffUL)
> +#define PCI_ROM_ADDRESS_MASK (~0x7ffU)
Does this mean we can remove the "(u32)" casts in __pci_read_base() and
pci_std_update_resource()? If so, can you do that in the same patch?
> #define PCI_CAPABILITY_LIST 0x34 /* Offset of first capability list entry */
>
> --
> 2.12.2.715.g7642488e1d-goog
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] PCI: Make PCI_ROM_ADDRESS_MASK a 32-bit constant
2017-04-14 15:43 ` Bjorn Helgaas
@ 2017-04-14 19:36 ` Matthias Kaehlcke
0 siblings, 0 replies; 3+ messages in thread
From: Matthias Kaehlcke @ 2017-04-14 19:36 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: Bjorn Helgaas, linux-pci, linux-kernel, Mason, Grant Grundler,
Greg Hackmann, Michael Davidson
El Fri, Apr 14, 2017 at 10:43:40AM -0500 Bjorn Helgaas ha dit:
> On Tue, Apr 11, 2017 at 10:56:58AM -0700, Matthias Kaehlcke wrote:
> > A 64-bit value is not needed since a PCI ROM address consists in 32 bits.
> > This fixes a clang warning about "implicit conversion from 'unsigned
> > long' to 'u32'".
> >
> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> > ---
> > Changes in v2:
> > - Define PCI_ROM_ADDRESS_MASK as a 32-bit constant instead of using a cast
> > - Updated commit message
> >
> > include/uapi/linux/pci_regs.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/uapi/linux/pci_regs.h b/include/uapi/linux/pci_regs.h
> > index 634c9c44ed6c..fff521c9458c 100644
> > --- a/include/uapi/linux/pci_regs.h
> > +++ b/include/uapi/linux/pci_regs.h
> > @@ -114,7 +114,7 @@
> > #define PCI_SUBSYSTEM_ID 0x2e
> > #define PCI_ROM_ADDRESS 0x30 /* Bits 31..11 are address, 10..1 reserved */
> > #define PCI_ROM_ADDRESS_ENABLE 0x01
> > -#define PCI_ROM_ADDRESS_MASK (~0x7ffUL)
> > +#define PCI_ROM_ADDRESS_MASK (~0x7ffU)
>
> Does this mean we can remove the "(u32)" casts in __pci_read_base() and
> pci_std_update_resource()?
Indeed
> If so, can you do that in the same patch?
Will do
Matthias
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-14 19:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-11 17:56 [PATCH v2] PCI: Make PCI_ROM_ADDRESS_MASK a 32-bit constant Matthias Kaehlcke
2017-04-14 15:43 ` Bjorn Helgaas
2017-04-14 19:36 ` Matthias Kaehlcke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).