From: Christoph Hellwig <hch@lst.de>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Linux ACPI <linux-acpi@vger.kernel.org>,
tpmdd-devel@lists.sourceforge.net,
intel-gfx@lists.freedesktop.org, nouveau@lists.freedesktop.org,
linux-input@vger.kernel.org, iommu@lists.linux-foundation.org,
linux-mmc@vger.kernel.org, Netdev <netdev@vger.kernel.org>,
linux-pci@vger.kernel.org, USB list <linux-usb@vger.kernel.org>,
alsa-devel@alsa-project.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Borislav Petkov <bp@suse.de>,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
Ben Skeggs <bskeggs@redhat.com>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Joerg Roedel <joro@8bytes.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Yisen Zhuang <yisen.zhuang@huawei.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Zhang Rui <rui.zhang@intel.com>, Felipe Balbi <balbi@kernel.org>,
Mathias Nyman <mathias.nyman@intel.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v1] ACPI: Switch to use generic UUID API
Date: Fri, 5 May 2017 11:57:39 +0200 [thread overview]
Message-ID: <20170505095739.GB6762@lst.de> (raw)
In-Reply-To: <CAOQ4uxjErce01+xyDnM=nCJS+avQ4g6hQVvH3fVotj7Ws2moCQ@mail.gmail.com>
On Fri, May 05, 2017 at 12:50:31PM +0300, Amir Goldstein wrote:
> To complete the picture for folks not cc'ed on my patches,
> xfs use case suggests there is also justification for the additional helpers:
>
> uuid_is_null() / uuid_equal()
> guid_is_null() / guid_equal()
The is_null is useful and I bet we'll find other instances. I'm
not sure _equals really adds much value over the existing _cmp
helpers, but on the other hand they are so trivial that we might as
well add them.
The other thing XFS has is uuid_copy.
next prev parent reply other threads:[~2017-05-05 9:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-04 9:21 [PATCH v1] ACPI: Switch to use generic UUID API Andy Shevchenko
2017-05-04 9:37 ` Jani Nikula
2017-05-04 12:14 ` Heikki Krogerus
2017-05-04 12:46 ` Joerg Roedel
2017-05-04 13:51 ` Bjorn Helgaas
2017-05-04 15:29 ` Benjamin Tissoires
2017-05-05 6:04 ` [Intel-gfx] " kbuild test robot
2017-05-05 6:20 ` Dan Williams
2017-05-05 7:06 ` Amir Goldstein
2017-05-05 7:30 ` Christoph Hellwig
2017-05-05 9:24 ` Andy Shevchenko
2017-05-05 9:50 ` Amir Goldstein
2017-05-05 9:57 ` Christoph Hellwig [this message]
2017-05-05 10:02 ` Amir Goldstein
2017-05-09 7:56 ` Felipe Balbi
2017-05-09 8:22 ` Mathias Nyman
2017-05-10 1:20 ` Zhang Rui
2017-05-22 19:08 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170505095739.GB6762@lst.de \
--to=hch@lst.de \
--cc=adrian.hunter@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=amir73il@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=balbi@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=bhelgaas@google.com \
--cc=bp@suse.de \
--cc=broonie@kernel.org \
--cc=bskeggs@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jani.nikula@linux.intel.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=joro@8bytes.org \
--cc=lgirdwood@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).