From: Keith Busch <keith.busch@intel.com>
To: Wei Zhang <wzhang@fb.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Wesley Yung <wesley.yung@microsemi.com>,
Sammy Hui <sammy.hui@intel.com>,
Joseph Gruher <joseph.r.gruher@intel.com>,
Krishna Dhulipala <krishnad@fb.com>
Subject: Re: [PATCH 1/2] pcie/dpc: Skip DPC event if device is not present
Date: Wed, 10 May 2017 12:44:53 -0400 [thread overview]
Message-ID: <20170510164452.GE2572@localhost.localdomain> (raw)
In-Reply-To: <9D9314D9-2EA5-45C1-AC60-54F7658FD4BC@fb.com>
On Wed, May 10, 2017 at 04:35:06PM +0000, Wei Zhang wrote:
> Hi Keith,
>
> I see. I thought the current CPU root complex does not support such a use case, ie removing the DPC switch device itself and might result in kernel panic. But I agree this will make the code future-proof when CPU does support such a case in the future.
What do you mean in the future? I do this today (hotplug enclosures),
but I need this fix in place otherwise we get a use-after-free when
the DPC work queue runs after the hotplug code freed the topology that
includes the DPC parts.
next prev parent reply other threads:[~2017-05-10 16:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 16:02 [PATCH 0/2] pcie/dpc: Fixes Keith Busch
2017-04-28 16:02 ` [PATCH 1/2] pcie/dpc: Skip DPC event if device is not present Keith Busch
2017-05-10 3:39 ` Wei Zhang
2017-05-10 13:17 ` Keith Busch
2017-05-10 14:16 ` Wesley Yung
2017-05-10 16:35 ` Wei Zhang
2017-05-10 16:44 ` Keith Busch [this message]
2017-05-10 16:43 ` Wesley Yung
2017-05-10 16:52 ` Wesley Yung
2017-05-10 17:42 ` Keith Busch
2017-04-28 16:02 ` [PATCH 2/2] pcie/dpc: Fix control register setting Keith Busch
2017-05-22 23:43 ` [PATCH 0/2] pcie/dpc: Fixes Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170510164452.GE2572@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=bhelgaas@google.com \
--cc=joseph.r.gruher@intel.com \
--cc=krishnad@fb.com \
--cc=linux-pci@vger.kernel.org \
--cc=sammy.hui@intel.com \
--cc=wesley.yung@microsemi.com \
--cc=wzhang@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).