linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Daney <david.daney@cavium.com>
To: Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org
Cc: Jon Masters <jcm@redhat.com>,
	Robert Richter <robert.richter@cavium.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	David Daney <david.daney@cavium.com>
Subject: [PATCH 0/2] PCI: Workaround for bus reset on Cavium cn8xxx root ports
Date: Mon, 15 May 2017 17:17:34 -0700	[thread overview]
Message-ID: <20170516001736.4001-1-david.daney@cavium.com> (raw)

With the recent improvements in arm64 and vfio-pci, we are seeing
failures like this (on cn8890 based systems):

[  235.622361] Unhandled fault: synchronous external abort (0x96000210) at 0xfffffc00c1000100
[  235.630625] Internal error: : 96000210 [#1] PREEMPT SMP
.
.
.
[  236.208820] [<fffffc0008411250>] pci_generic_config_read+0x38/0x9c
[  236.214992] [<fffffc0008435ed4>] thunder_pem_config_read+0x54/0x1e8
[  236.221250] [<fffffc0008411620>] pci_bus_read_config_dword+0x74/0xa0
[  236.227596] [<fffffc000841853c>] pci_find_next_ext_capability.part.15+0x40/0xb8
[  236.234896] [<fffffc0008419428>] pci_find_ext_capability+0x20/0x30
[  236.241068] [<fffffc0008423e2c>] pci_restore_vc_state+0x34/0x88
[  236.246979] [<fffffc000841af3c>] pci_restore_state.part.37+0x2c/0x1fc
[  236.253410] [<fffffc000841b174>] pci_dev_restore+0x4c/0x50
[  236.258887] [<fffffc000841b19c>] pci_bus_restore+0x24/0x4c
[  236.264362] [<fffffc000841c2dc>] pci_try_reset_bus+0x7c/0xa0
[  236.270021] [<fffffc00060a1ab0>] vfio_pci_ioctl+0xc34/0xc3c [vfio_pci]
[  236.276547] [<fffffc0005eb0410>] vfio_device_fops_unl_ioctl+0x20/0x30 [vfio]
[  236.283587] [<fffffc000824b314>] do_vfs_ioctl+0xac/0x744
[  236.288890] [<fffffc000824ba30>] SyS_ioctl+0x84/0x98
[  236.293846] [<fffffc0008082ca0>] __sys_trace_return+0x0/0x4

These are caused by the inability of the PCIe root port and Intel
e1000e to sucessfully do a bus reset.

The proposed fix is to not do a bus reset on these systems.

David Daney (2):
  PCI: Allow PCI_DEV_FLAGS_NO_BUS_RESET to be used on bus device.
  PCI: Avoid bus reset for Cavium cn8xxx root ports.

 drivers/pci/pci.c    | 4 ++++
 drivers/pci/quirks.c | 8 ++++++++
 2 files changed, 12 insertions(+)

-- 
2.9.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

             reply	other threads:[~2017-05-16  0:17 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-16  0:17 David Daney [this message]
2017-05-16  0:17 ` [PATCH 1/2] PCI: Allow PCI_DEV_FLAGS_NO_BUS_RESET to be used on bus device David Daney
2017-05-16 20:14   ` Auger Eric
2017-05-16  0:17 ` [PATCH 2/2] PCI: Avoid bus reset for Cavium cn8xxx root ports David Daney
2017-05-16 20:14   ` Auger Eric
2017-05-16 20:29     ` David Daney
2017-05-16 20:48       ` Alex Williamson
2017-05-17  7:07       ` Joe Perches
2017-05-17 14:04         ` Jon Masters
2017-05-16 20:14 ` [PATCH 0/2] PCI: Workaround for bus reset on " Auger Eric
2017-05-23 20:47 ` Bjorn Helgaas
2017-05-23 21:04   ` Alex Williamson
2017-05-23 21:20     ` Bjorn Helgaas
2017-05-23 21:22     ` David Daney
2017-05-23 22:15       ` Alex Williamson
2017-05-30  3:30         ` Jon Masters
2017-05-30 17:32           ` Alex Williamson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170516001736.4001-1-david.daney@cavium.com \
    --to=david.daney@cavium.com \
    --cc=bhelgaas@google.com \
    --cc=jcm@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=robert.richter@cavium.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).