From: Christoph Hellwig <hch@infradead.org>
To: Gabriele Paoloni <gabriele.paoloni@huawei.com>
Cc: bhelgaas@google.com, helgaas@kernel.org, linuxarm@huawei.com,
linux-pci@vger.kernel.org, lukas@wunner.de,
linux-kernel@vger.kernel.org, mika.westerberg@linux.intel.com,
hch@infradead.org, liudongdong3@huawei.com
Subject: Re: [PATCH v3 1/2] PCI/portdrv: add support for different MSI interrupts for PCIe port services
Date: Sun, 21 May 2017 01:32:34 -0700 [thread overview]
Message-ID: <20170521083234.GA20658@infradead.org> (raw)
In-Reply-To: <1495103748-7876-2-git-send-email-gabriele.paoloni@huawei.com>
> + *
> + * pci_irq_vector() below is able to handle entry differently
> + * depending on MSI vs MSI-x case
> + *
> */
One more instance of this comment left :)
> pcie_capability_read_word(dev, PCI_EXP_FLAGS, ®16);
> entry = (reg16 & PCI_EXP_FLAGS_IRQ) >> 9;
> @@ -100,7 +107,10 @@ static int pcie_port_enable_msix(struct pci_dev *dev, int *irqs, int mask)
> * MSI/MSI-X vectors assigned to the port is going to be used
> * for AER, where "For MSI-X, the value in this register
> * indicates which MSI-X Table entry is used to generate the
> - * interrupt message."
> + * interrupt message." and "For MSI, the value
> + * in this field indicates the offset between the base Message
> + * Data and the interrupt message that is generated."
> + *
> */
And while this is getting a little too deep into nitpicking: we usually
don't add empty lines to the end of comments.
next prev parent reply other threads:[~2017-05-21 8:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 10:35 [PATCH v3 0/2] add MSI support for PCIe port services and DPC IRQ support Gabriele Paoloni
2017-05-18 10:35 ` [PATCH v3 1/2] PCI/portdrv: add support for different MSI interrupts for PCIe port services Gabriele Paoloni
2017-05-21 8:32 ` Christoph Hellwig [this message]
2017-05-21 15:00 ` Gabriele Paoloni
2017-05-22 17:44 ` Christoph Hellwig
2017-05-23 14:25 ` Gabriele Paoloni
2017-05-18 10:35 ` [PATCH v3 2/2] PCI/portdrv: allocate MSI/MSIx vector for DPC RP service Gabriele Paoloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170521083234.GA20658@infradead.org \
--to=hch@infradead.org \
--cc=bhelgaas@google.com \
--cc=gabriele.paoloni@huawei.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liudongdong3@huawei.com \
--cc=lukas@wunner.de \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).