From: Christoph Hellwig <hch@infradead.org>
To: Gabriele Paoloni <gabriele.paoloni@huawei.com>
Cc: Christoph Hellwig <hch@infradead.org>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"helgaas@kernel.org" <helgaas@kernel.org>,
Linuxarm <linuxarm@huawei.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"lukas@wunner.de" <lukas@wunner.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mika.westerberg@linux.intel.com"
<mika.westerberg@linux.intel.com>,
"liudongdong (C)" <liudongdong3@huawei.com>
Subject: Re: [PATCH v3 1/2] PCI/portdrv: add support for different MSI interrupts for PCIe port services
Date: Mon, 22 May 2017 10:44:11 -0700 [thread overview]
Message-ID: <20170522174411.GA29861@infradead.org> (raw)
In-Reply-To: <EE11001F9E5DDD47B7634E2F8A612F2E40A45545@FRAEML521-MBX.china.huawei.com>
On Sun, May 21, 2017 at 03:00:46PM +0000, Gabriele Paoloni wrote:
>
> I thought that in your previous review you meant to say that we should
> avoid 2 instances of the same comment (in this patchset I only have this
> instance as I have removed the same comment from patch 2/2...)
No, there is no pointin the comment. The whole point of pci_irq_vector
is to abstract away from how to get at the interrupt in detail. There
is no need to comment on this at the callsite. If you think the
existing documentation for the function is not good enough send a patch
to improve it there instead of commenting the callsites.
next prev parent reply other threads:[~2017-05-22 17:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 10:35 [PATCH v3 0/2] add MSI support for PCIe port services and DPC IRQ support Gabriele Paoloni
2017-05-18 10:35 ` [PATCH v3 1/2] PCI/portdrv: add support for different MSI interrupts for PCIe port services Gabriele Paoloni
2017-05-21 8:32 ` Christoph Hellwig
2017-05-21 15:00 ` Gabriele Paoloni
2017-05-22 17:44 ` Christoph Hellwig [this message]
2017-05-23 14:25 ` Gabriele Paoloni
2017-05-18 10:35 ` [PATCH v3 2/2] PCI/portdrv: allocate MSI/MSIx vector for DPC RP service Gabriele Paoloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170522174411.GA29861@infradead.org \
--to=hch@infradead.org \
--cc=bhelgaas@google.com \
--cc=gabriele.paoloni@huawei.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liudongdong3@huawei.com \
--cc=lukas@wunner.de \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).