From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shards.monkeyblade.net ([184.105.139.130]:51496 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161578AbdEYACx (ORCPT ); Wed, 24 May 2017 20:02:53 -0400 Date: Wed, 24 May 2017 20:02:49 -0400 (EDT) Message-Id: <20170524.200249.1492095559302424098.davem@davemloft.net> To: myron.stowe@redhat.com Cc: linux-pci@vger.kernel.org, netdev@vger.kernel.org, bhelgaas@google.com, saeedm@mellanox.com, noaos@mellanox.com, tariqt@mellanox.com Subject: Re: [PATCH 0/2] Replace driver's usage of hard-coded device IDs to #defines From: David Miller In-Reply-To: <20170524224734.24221.33787.stgit@amt.stowe> References: <20170524224734.24221.33787.stgit@amt.stowe> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Sender: linux-pci-owner@vger.kernel.org List-ID: From: Myron Stowe Date: Wed, 24 May 2017 16:47:34 -0600 > Noa Osherovich introduced a series of new Mellanox device ID definitions to > help differentiate specific controllers that needed INTx masking quirks [1]. > > Bjorn Helgaas followed on, using the device ID definitions Noa provided to > replace hard-coded values within the mxl4 ID table [2]. > > This patch continues along similar lines, adding a few additional Mellanox > device ID definitions and converting the net/mlx5e driver's mlx5 ID table to > use the defines so tools like 'grep' and 'cscope' can be used to help > identify relationships with other aspects (such as INTx masking). If you're adding pci_ids.h defines, it's only valid to do so if you actually use the defines in more than one location. This patch series is not doing that.