From: Alex Williamson <alex.williamson@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: kvm@vger.kernel.org,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Stefan Assmann <sassmann@redhat.com>,
linux-kernel@vger.kernel.org,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH] vfio/pci: Add Intel XXV710 to hidden INTx devices
Date: Thu, 8 Jun 2017 07:06:09 -0600 [thread overview]
Message-ID: <20170608070609.435a7187@t450s.home> (raw)
In-Reply-To: <20170608080017.GA12580@infradead.org>
[+linux-pci]
On Thu, 8 Jun 2017 01:00:17 -0700
Christoph Hellwig <hch@infradead.org> wrote:
> On Wed, Jun 07, 2017 at 01:01:46PM -0600, Alex Williamson wrote:
> > XXV710 has the same broken INTx behavior as the rest of the X/XL710
> > series, the interrupt status register is not wired to report pending
> > INTx interrupts, thus we never associate the interrupt to the device.
> > Extend the device IDs to include these so that we hide that the
> > device supports INTx at all to the user.
>
> Is vfio really the right place for the list? Shouldn't this be
> keyed off the core PCI quirk for these devices?
I sent a separate patch to add these devices to the regular broken INTx
quirk in pci-core:
http://www.spinics.net/lists/linux-pci/msg61971.html
We don't currently have a device flag to specify that INTx is broken in
this particular way that vfio can work around, nor do I really know how
other drivers might make use of this info. If I'm wrong, then
certainly let's make a common way to do this, but this patch is just a
trivial extension to an existing mechanism. Thanks,
Alex
parent reply other threads:[~2017-06-08 13:06 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20170608080017.GA12580@infradead.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170608070609.435a7187@t450s.home \
--to=alex.williamson@redhat.com \
--cc=hch@infradead.org \
--cc=jesse.brandeburg@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).