linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] vfio/pci: Add Intel XXV710 to hidden INTx devices
       [not found] ` <20170608080017.GA12580@infradead.org>
@ 2017-06-08 13:06   ` Alex Williamson
  0 siblings, 0 replies; only message in thread
From: Alex Williamson @ 2017-06-08 13:06 UTC (permalink / raw)
  To: Christoph Hellwig
  Cc: kvm, Jesse Brandeburg, Stefan Assmann, linux-kernel,
	linux-pci@vger.kernel.org

[+linux-pci]

On Thu, 8 Jun 2017 01:00:17 -0700
Christoph Hellwig <hch@infradead.org> wrote:

> On Wed, Jun 07, 2017 at 01:01:46PM -0600, Alex Williamson wrote:
> > XXV710 has the same broken INTx behavior as the rest of the X/XL710
> > series, the interrupt status register is not wired to report pending
> > INTx interrupts, thus we never associate the interrupt to the device.
> > Extend the device IDs to include these so that we hide that the
> > device supports INTx at all to the user.  
> 
> Is vfio really the right place for the list?  Shouldn't this be
> keyed off the core PCI quirk for these devices?

I sent a separate patch to add these devices to the regular broken INTx
quirk in pci-core:

http://www.spinics.net/lists/linux-pci/msg61971.html

We don't currently have a device flag to specify that INTx is broken in
this particular way that vfio can work around, nor do I really know how
other drivers might make use of this info.  If I'm wrong, then
certainly let's make a common way to do this, but this patch is just a
trivial extension to an existing mechanism.  Thanks,

Alex

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-06-08 13:06 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20170607190132.22711.46831.stgit@gimli.home>
     [not found] ` <20170608080017.GA12580@infradead.org>
2017-06-08 13:06   ` [PATCH] vfio/pci: Add Intel XXV710 to hidden INTx devices Alex Williamson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).