linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] PCI: Add Intel XXV710 to broken INTx masking quirk
@ 2017-06-07 19:00 Alex Williamson
  2017-06-08 17:18 ` Jesse Brandeburg
  2017-06-12 21:56 ` Bjorn Helgaas
  0 siblings, 2 replies; 3+ messages in thread
From: Alex Williamson @ 2017-06-07 19:00 UTC (permalink / raw)
  To: linux-pci; +Cc: bhelgaas, Jesse Brandeburg, Stefan Assmann, linux-kernel

Just like the other XL710 and X710 variants, the XXV710 device IDs
appear to have the same hardware bug, the status register doesn't
report pending interrupts resulting in "irq xx: nobody cared..."
errors from the spurious interrupt handler when we try to use it
with device assignment.

Reported-by: Stefan Assmann <sassmann@redhat.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
---
 drivers/pci/quirks.c |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 16e6cd86ad71..aa1c9e65f562 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -3236,6 +3236,10 @@ static void quirk_broken_intx_masking(struct pci_dev *dev)
 			quirk_broken_intx_masking);
 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x1589,
 			quirk_broken_intx_masking);
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x158a,
+			quirk_broken_intx_masking);
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x158b,
+			quirk_broken_intx_masking);
 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x37d0,
 			quirk_broken_intx_masking);
 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x37d1,

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] PCI: Add Intel XXV710 to broken INTx masking quirk
  2017-06-07 19:00 [PATCH] PCI: Add Intel XXV710 to broken INTx masking quirk Alex Williamson
@ 2017-06-08 17:18 ` Jesse Brandeburg
  2017-06-12 21:56 ` Bjorn Helgaas
  1 sibling, 0 replies; 3+ messages in thread
From: Jesse Brandeburg @ 2017-06-08 17:18 UTC (permalink / raw)
  To: Alex Williamson; +Cc: linux-pci, bhelgaas, Stefan Assmann, linux-kernel

On Wed, 7 Jun 2017 13:00:48 -0600
Alex Williamson <alex.williamson@redhat.com> wrote:

> Just like the other XL710 and X710 variants, the XXV710 device IDs
> appear to have the same hardware bug, the status register doesn't
> report pending interrupts resulting in "irq xx: nobody cared..."
> errors from the spurious interrupt handler when we try to use it
> with device assignment.

Thanks for doing this Alex,

Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] PCI: Add Intel XXV710 to broken INTx masking quirk
  2017-06-07 19:00 [PATCH] PCI: Add Intel XXV710 to broken INTx masking quirk Alex Williamson
  2017-06-08 17:18 ` Jesse Brandeburg
@ 2017-06-12 21:56 ` Bjorn Helgaas
  1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2017-06-12 21:56 UTC (permalink / raw)
  To: Alex Williamson
  Cc: linux-pci, bhelgaas, Jesse Brandeburg, Stefan Assmann,
	linux-kernel

On Wed, Jun 07, 2017 at 01:00:48PM -0600, Alex Williamson wrote:
> Just like the other XL710 and X710 variants, the XXV710 device IDs
> appear to have the same hardware bug, the status register doesn't
> report pending interrupts resulting in "irq xx: nobody cared..."
> errors from the spurious interrupt handler when we try to use it
> with device assignment.
> 
> Reported-by: Stefan Assmann <sassmann@redhat.com>
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>

Applied with Jesse's ack to pci/virtualization for v4.13, thanks!

> ---
>  drivers/pci/quirks.c |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 16e6cd86ad71..aa1c9e65f562 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -3236,6 +3236,10 @@ static void quirk_broken_intx_masking(struct pci_dev *dev)
>  			quirk_broken_intx_masking);
>  DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x1589,
>  			quirk_broken_intx_masking);
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x158a,
> +			quirk_broken_intx_masking);
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x158b,
> +			quirk_broken_intx_masking);
>  DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x37d0,
>  			quirk_broken_intx_masking);
>  DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x37d1,
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-06-12 21:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-07 19:00 [PATCH] PCI: Add Intel XXV710 to broken INTx masking quirk Alex Williamson
2017-06-08 17:18 ` Jesse Brandeburg
2017-06-12 21:56 ` Bjorn Helgaas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).