* [PATCH] PCI: vmd: Correct comment: VMD domains start at 0x10000, not 0x1000
@ 2017-06-19 20:36 Bjorn Helgaas
2017-06-19 20:57 ` Keith Busch
2017-06-19 23:16 ` Bjorn Helgaas
0 siblings, 2 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2017-06-19 20:36 UTC (permalink / raw)
To: Keith Busch; +Cc: linux-pci
VMD domains are allocated starting at 0x10000, not 0x1000 as the comment
said. Correct the comment and add a reference to the ACPI spec for _SEG.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
drivers/pci/host/vmd.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/host/vmd.c b/drivers/pci/host/vmd.c
index e27ad2a3bd33..53aa1d4b17e8 100644
--- a/drivers/pci/host/vmd.c
+++ b/drivers/pci/host/vmd.c
@@ -539,7 +539,10 @@ static void vmd_detach_resources(struct vmd_dev *vmd)
}
/*
- * VMD domains start at 0x1000 to not clash with ACPI _SEG domains.
+ * VMD domains start at 0x10000 to not clash with ACPI _SEG domains.
+ * Per ACPI r6.0, sec 6.5.6, _SEG returns an integer, of which the lower
+ * 16 bits are the PCI Segment Group (domain) number. Other bits are
+ * currently reserved.
*/
static int vmd_find_free_domain(void)
{
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] PCI: vmd: Correct comment: VMD domains start at 0x10000, not 0x1000
2017-06-19 20:36 [PATCH] PCI: vmd: Correct comment: VMD domains start at 0x10000, not 0x1000 Bjorn Helgaas
@ 2017-06-19 20:57 ` Keith Busch
2017-06-19 23:16 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Keith Busch @ 2017-06-19 20:57 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: linux-pci
On Mon, Jun 19, 2017 at 03:36:01PM -0500, Bjorn Helgaas wrote:
> VMD domains are allocated starting at 0x10000, not 0x1000 as the comment
> said. Correct the comment and add a reference to the ACPI spec for _SEG.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Indeed, thanks for the fix.
Reviewed-by: Keith Busch <keith.busch@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI: vmd: Correct comment: VMD domains start at 0x10000, not 0x1000
2017-06-19 20:36 [PATCH] PCI: vmd: Correct comment: VMD domains start at 0x10000, not 0x1000 Bjorn Helgaas
2017-06-19 20:57 ` Keith Busch
@ 2017-06-19 23:16 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2017-06-19 23:16 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: Keith Busch, linux-pci
On Mon, Jun 19, 2017 at 03:36:01PM -0500, Bjorn Helgaas wrote:
> VMD domains are allocated starting at 0x10000, not 0x1000 as the comment
> said. Correct the comment and add a reference to the ACPI spec for _SEG.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Applied with Keith's reviewed-by to pci/host-vmd for v4.13.
> ---
> drivers/pci/host/vmd.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/vmd.c b/drivers/pci/host/vmd.c
> index e27ad2a3bd33..53aa1d4b17e8 100644
> --- a/drivers/pci/host/vmd.c
> +++ b/drivers/pci/host/vmd.c
> @@ -539,7 +539,10 @@ static void vmd_detach_resources(struct vmd_dev *vmd)
> }
>
> /*
> - * VMD domains start at 0x1000 to not clash with ACPI _SEG domains.
> + * VMD domains start at 0x10000 to not clash with ACPI _SEG domains.
> + * Per ACPI r6.0, sec 6.5.6, _SEG returns an integer, of which the lower
> + * 16 bits are the PCI Segment Group (domain) number. Other bits are
> + * currently reserved.
> */
> static int vmd_find_free_domain(void)
> {
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-19 23:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-19 20:36 [PATCH] PCI: vmd: Correct comment: VMD domains start at 0x10000, not 0x1000 Bjorn Helgaas
2017-06-19 20:57 ` Keith Busch
2017-06-19 23:16 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).