Re: [PATCH] pci: Add and use PCI_GENERIC_SETUP Kconfig entry

From: James Hogan <james.hogan@imgtec.com>
To: Palmer Dabbelt <palmer@dabbelt.com>
Cc: linux-mips@linux-mips.org, dalias@libc.org,
	linux-sh@vger.kernel.org, catalin.marinas@arm.com,
	will.deacon@arm.com, sparclinux@vger.kernel.org,
	gxt@mprc.pku.edu.cn, ysato@users.sourceforge.jp,
	linux@armlinux.org.uk, hch@infradead.org, geert@linux-m68k.org,
	linux-pci@vger.kernel.org, mattst88@gmail.com,
	linux-snps-arc@lists.infradead.org, cmetcalf@mellanox.com,
	linux-m68k@lists.linux-m68k.org, ink@jurassic.park.msu.ru,
	viro@zeniv.linux.org.uk, bhelgaas@google.com,
	linux-arm-kernel@lists.infradead.org, rth@twiddle.net,
	vgupta@synopsys.com, linux-kernel@vger.kernel.org,
	ralf@linux-mips.org, linux-alpha@vger.kernel.org,
	akpm@linux-foundation.org, davem@davemloft.net
Subject: Re: [PATCH] pci:  Add and use PCI_GENERIC_SETUP Kconfig entry
Date: Fri, 23 Jun 2017 23:01:04 +0100	[thread overview]
Message-ID: <20170623220104.GE31455@jhogan-linux.le.imgtec.org> (raw)
In-Reply-To: <20170623214538.25967-1-palmer@dabbelt.com>

[-- Attachment #1.1: Type: text/plain, Size: 1271 bytes --]

On Fri, Jun 23, 2017 at 02:45:38PM -0700, Palmer Dabbelt wrote:
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 4c1a35f15838..86872246951c 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -96,6 +96,7 @@ config ARM
>  	select PERF_USE_VMALLOC
>  	select RTC_LIB
>  	select SYS_SUPPORTS_APM_EMULATION
> +	select PCI_GENERIC_SETUP
>  	# Above selects are sorted alphabetically; please add new ones
>  	# according to that.  Thanks.

This comment seems to suggest PCI_GENERIC_SETUP should be added a few
lines up to preserve the alphabetical sorting.

> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index b2024db225a9..6c684d8c8816 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -115,6 +115,7 @@ config ARM64
>  	select SPARSE_IRQ
>  	select SYSCTL_EXCEPTION_TRACE
>  	select THREAD_INFO_IN_TASK
> +	select PCI_GENERIC_SETUP

Here too.

> diff --git a/arch/tile/Kconfig b/arch/tile/Kconfig
> index 4583c0320059..6679af85a882 100644
> --- a/arch/tile/Kconfig
> +++ b/arch/tile/Kconfig
> @@ -33,6 +33,7 @@ config TILE
>  	select USER_STACKTRACE_SUPPORT
>  	select USE_PMC if PERF_EVENTS
>  	select VIRT_TO_BUS
> +	select PCI_GENERIC_SETUP

and here

Otherwise
Reviewed-by: James Hogan <james.hogan@imgtec.com>

Cheers
James

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel