From: Stephen Hemminger <stephen@networkplumber.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: kys@microsoft.com, bhelgaas@google.com,
linux-pci@vger.kernel.org, devel@linuxdriverproject.org,
Stephen Hemminger <sthemmin@microsoft.com>
Subject: Re: [PATCH] hv: fix msi affinity when device requests all possible CPU's
Date: Wed, 5 Jul 2017 13:07:11 -0700 [thread overview]
Message-ID: <20170705130711.12844794@xeon-e3> (raw)
In-Reply-To: <20170705194933.GN13824@bhelgaas-glaptop.roam.corp.google.com>
On Wed, 5 Jul 2017 14:49:33 -0500
Bjorn Helgaas <helgaas@kernel.org> wrote:
> On Tue, Jul 04, 2017 at 02:59:42PM -0700, Stephen Hemminger wrote:
> > On Sun, 2 Jul 2017 16:38:19 -0500
> > Bjorn Helgaas <helgaas@kernel.org> wrote:
> >
> > > On Wed, Jun 28, 2017 at 04:22:04PM -0700, Stephen Hemminger wrote:
> > > > When Intel 10G (ixgbevf) is passed to a Hyper-V guest with SR-IOV,
> > > > the driver requests affinity with all possible CPU's (0-239) even
> > > > those CPU's are not online (and will never be). Because of this the device
> > > > is unable to correctly get MSI interrupt's setup.
> > > >
> > > > This was caused by the change in 4.12 that converted this affinity
> > > > into all possible CPU's (0-31) but then host reports
> > > > an error since this is larger than the number of online cpu's.
> > > >
> > > > Previously, this worked (up to 4.12-rc1) because only online cpu's
> > > > would be put in mask passed to the host.
> > > >
> > > > This patch applies only to 4.12.
> > > > The driver in linux-next needs a a different fix because of the changes
> > > > to PCI host protocol version.
> > >
> > > If Linus decides to postpone v4.12 a week, I can ask him to pull this. But
> > > I suspect he will release v4.12 today. In that case, I don't know what to
> > > do with this other than maybe send it to Greg for a -stable release.
> >
> > Looks like this will have to be queued for 4.12 stable.
>
> I assume you'll take care of this, right? It sounds like there's nothing
> to do for upstream because it needs a different fix.
>
> Bjorn
Already fixed in Linux-next. The code is different for PCI 1.2
version and never had the bug.
prev parent reply other threads:[~2017-07-05 20:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 23:22 [PATCH] hv: fix msi affinity when device requests all possible CPU's Stephen Hemminger
[not found] ` <DM5PR21MB0476CFFA739B74FBB3B6F42DA0D20@DM5PR21MB0476.namprd21.prod.outlook.com>
2017-06-29 22:08 ` Jork Loeser
2017-06-29 23:57 ` Stephen Hemminger
2017-07-02 21:38 ` Bjorn Helgaas
2017-07-04 21:59 ` Stephen Hemminger
2017-07-05 19:49 ` Bjorn Helgaas
2017-07-05 20:07 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170705130711.12844794@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=bhelgaas@google.com \
--cc=devel@linuxdriverproject.org \
--cc=helgaas@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-pci@vger.kernel.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).