From: Christoph Hellwig <hch@lst.de>
To: chris hyser <chris.hyser@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
Alan Adamson <alan.adamson@oracle.com>,
keith.busch@intel.com, axboe@fb.com,
linux-nvme@lists.infradead.org, sagi@grimberg.me,
linux-pci@vger.kernel.org, Mark Nelson <markn@au1.ibm.com>,
Arnd Bergmann <arnd@arndb.de>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
iommu@lists.linux-foundation.org
Subject: Re: DMA_ATTR_WEAK_ORDERING defintion, was Re: [PATCH] nvme: set DMA_ATTR_WEAK_ORDERING attribute on dma buffers
Date: Wed, 5 Jul 2017 21:07:14 +0200 [thread overview]
Message-ID: <20170705190714.GA7107@lst.de> (raw)
In-Reply-To: <f485b21a-0cf7-d2f0-c957-03d234447561@oracle.com>
On Tue, Jun 27, 2017 at 04:46:31PM -0400, chris hyser wrote:
> I put this in for SPARC. In our case the host bridge/RC itself follows very
> strict ordering unless the relaxed order bit is set in the TLP. This works
> great for devices that actually allow the driver to enable it. We however
> also have to support an infiniband card that does not support enabling this
> in the HW and thus in the TLP but is actually fine with relaxed order for
> the data buffers (ie the streaming I/O vs the coherent control buffers). In
> fact w/o relaxed order the performance is absolutely atrocious ... w/
> exceeds x86. This flag enables the driver to signal to us when we map the
> buffer in the IOMMU to enable the relaxed order attribute for our HW.
We'll really need to start writing down our semantics. As I said
given how our streaming dma mappings (dma_map_single/page/sg) are
defined I can't think of any way how relaxed vs strict ordering would
matter for them, so just enabling it by default seems like the right
thing in this case, instead of having to patch every PCIe driver people
might ever use on sparc to work around your bridge.
next prev parent reply other threads:[~2017-07-05 19:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1497645290-31041-1-git-send-email-alan.adamson@oracle.com>
[not found] ` <20170617115703.GA13002@lst.de>
[not found] ` <6a32f30b-433a-9857-164f-1717405a6082@oracle.com>
2017-06-24 7:35 ` DMA_ATTR_WEAK_ORDERING defintion, was Re: [PATCH] nvme: set DMA_ATTR_WEAK_ORDERING attribute on dma buffers Christoph Hellwig
2017-06-26 9:15 ` Arnd Bergmann
2017-06-27 20:46 ` chris hyser
2017-07-05 19:07 ` Christoph Hellwig [this message]
2017-07-10 16:17 ` chris hyser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170705190714.GA7107@lst.de \
--to=hch@lst.de \
--cc=alan.adamson@oracle.com \
--cc=arnd@arndb.de \
--cc=axboe@fb.com \
--cc=benh@kernel.crashing.org \
--cc=chris.hyser@oracle.com \
--cc=iommu@lists.linux-foundation.org \
--cc=keith.busch@intel.com \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=markn@au1.ibm.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).