Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Alex Williamson <alex.williamson@redhat.com>
To: Feng Kan <fkan@apm.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
	"Jonglih (Daniel) Yu" <jyu@apm.com>,
	"jcm@redhat.com" <jcm@redhat.com>
Subject: Re: [PATCH] pci: quirk: Apply APM ACS quirk to XGene devices
Date: Thu, 20 Jul 2017 16:19:05 -0600	[thread overview]
Message-ID: <20170720161905.24e300eb@ul30vt.home> (raw)
In-Reply-To: <CAL85gmASr719MHsco8GpSfG+xyxkR2gSQA8KbpoAx_NAbRNJxQ@mail.gmail.com>

On Tue, 18 Jul 2017 22:37:00 -0700
Feng Kan <fkan@apm.com> wrote:

> >
> > I don't know what that means, does the hardware support an equivalent
> > to source validation or not?  
> 
> Yes, source validation is done through the smmu.

The SMMU does a context lookup based on the bdf, but if the root port
does not support SV, what is it that prevents the device from spoofing
a different bdf?  How does the smmu intercept this?  Thanks,

Alex
 
>   What's the response of the root port if
> > the downstream device issues a transaction spoofing devices not within
> > the bus number ranges of the bridge?  
> HW guys informs me there is way to disable transactions between root port.
> I will confirm later.
> 
> >  
> >> Alex, the goal here is to enable virtualization to work correctly.
> >> Please let me know if the
> >> above is sufficient. Much thanks.  
> >
> > Of course, but that means that the hardware vendor is vouching that
> > this device provides the equivalent isolation for each of the missing
> > components of ACS.  Claiming to have isolation capabilities that don't
> > exist would be irresponsible and put users of that hardware at risk.  
> Agreed, I believe we do have isolation in our case based on the conference
> we had today.
> 
> > Thanks,
> >
> > Alex  

      reply	other threads:[~2017-07-20 22:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-18  0:45 [PATCH] pci: quirk: Apply APM ACS quirk to XGene devices Feng Kan
2017-07-18  2:23 ` Alex Williamson
2017-07-18 17:42   ` Feng Kan
2017-07-18 18:16     ` Alex Williamson
2017-07-19  5:37       ` Feng Kan
2017-07-20 22:19         ` Alex Williamson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170720161905.24e300eb@ul30vt.home \
    --to=alex.williamson@redhat.com \
    --cc=bhelgaas@google.com \
    --cc=fkan@apm.com \
    --cc=jcm@redhat.com \
    --cc=jyu@apm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox