From: Keith Busch <keith.busch@intel.com>
To: Scott Bauer <scott.bauer@intel.com>
Cc: Jon Derrick <jonathan.derrick@intel.com>,
linux-pci@vger.kernel.org, david.fugate@intel.com,
bhelgaas@google.com
Subject: Re: [PATCH] PCI: vmd: Free up IRQs on suspend path
Date: Thu, 20 Jul 2017 18:41:27 -0400 [thread overview]
Message-ID: <20170720224126.GF1202@localhost.localdomain> (raw)
In-Reply-To: <20170720215654.nyfpvgzgny2bpqny@sbauer-Z170X-UD5>
On Thu, Jul 20, 2017 at 03:56:54PM -0600, Scott Bauer wrote:
> On Tue, Jul 25, 2017 at 08:36:10PM -0600, Jon Derrick wrote:
> >
> > I think we'll need to do more than free the irq handlers because if an
> > interrupt occurs after that, I think it'll get kicked to handle_bad_irq.
> > I think we just need to add pci_disable_device after save and
> > pcim_enable_device after restore.
>
> I orignally had this in the patch I was testing on SLES and took it out when
> it seemingly didn't make a difference. I didnt test yanking a drive or anything
> behind the domain while it was suspended, so I wouldn't have hit your scenario.
>
> I'll add it back in. Also, I think I need to CC stable on this one too since
> this is missing all the way since the original inception of this driver.
I think your patch should be okay as-is. After freeing VMD's IRQs,
the kernel will automatically clear the MSI-x control bit to disable it
from firing.
next prev parent reply other threads:[~2017-07-20 22:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-20 20:28 [PATCH] PCI: vmd: Free up IRQs on suspend path Scott Bauer
2017-07-26 2:15 ` Jon Derrick
2017-07-20 21:34 ` Scott Bauer
2017-07-26 2:36 ` Jon Derrick
2017-07-20 21:56 ` Scott Bauer
2017-07-20 22:41 ` Keith Busch [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-08-11 20:54 Scott Bauer
2017-08-14 18:06 ` Bjorn Helgaas
2017-08-14 18:15 ` Keith Busch
2017-08-14 20:30 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170720224126.GF1202@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=bhelgaas@google.com \
--cc=david.fugate@intel.com \
--cc=jonathan.derrick@intel.com \
--cc=linux-pci@vger.kernel.org \
--cc=scott.bauer@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).