From: Greg KH <gregkh@linuxfoundation.org>
To: Sandeep Singh <ssingh1@amd.com>
Cc: Sandeep Singh <Sandeep.Singh@amd.com>,
mathias.nyman@intel.com, bhelgaas@google.com,
dheitmueller@kernellabs.com, stern@rowland.harvard.edu,
samuel.thibault@ens-lyon.org, lukas@oxygene.sk,
linux-usb@vger.kernel.org, linux-pci@vger.kernel.org,
Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
Nehal Shah <Nehal-bakulchandra.Shah@amd.com>
Subject: Re: [PATCH] usb: xhci: Add quirk for Certain failing HP keyboard on reset after resume
Date: Mon, 31 Jul 2017 08:46:36 -0700 [thread overview]
Message-ID: <20170731154636.GA27596@kroah.com> (raw)
In-Reply-To: <060e5b58-07ff-4e2c-9739-d75c3c40c085@amd.com>
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Mon, Jul 31, 2017 at 12:10:08PM +0530, Sandeep Singh wrote:
> Hi Greg,
>
> Thanks for review. Apart from pci_ids.h, I see only 3 options, add this id as macro in pci_quirks.c
> or pci_quirks.h or just hardcode it.
>
> please suggest what will good option as per your view.
As you only use it in one place, why not just hardcode it there?
thanks,
greg k-h
prev parent reply other threads:[~2017-07-31 15:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-27 8:35 [PATCH] usb: xhci: Add quirk for Certain failing HP keyboard on reset after resume Sandeep Singh
2017-07-30 14:11 ` Greg KH
2017-07-31 6:40 ` Sandeep Singh
2017-07-31 15:46 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170731154636.GA27596@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Nehal-bakulchandra.Shah@amd.com \
--cc=Sandeep.Singh@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=bhelgaas@google.com \
--cc=dheitmueller@kernellabs.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lukas@oxygene.sk \
--cc=mathias.nyman@intel.com \
--cc=samuel.thibault@ens-lyon.org \
--cc=ssingh1@amd.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).