From: Stephen Hemminger <stephen@networkplumber.org>
To: kys@microsoft.com, haiyangz@microsoft.com,
sthemmin@microsoft.com, corbet@lwn.net
Cc: devel@linuxdriverproject.org, linux-doc@vger.kernel.org,
netdev@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH net-next 4/4] pci-hyperv: do not sleep in compose_msi_msg
Date: Mon, 31 Jul 2017 16:40:38 -0700 [thread overview]
Message-ID: <20170731164038.49bc878a@xeon-e3> (raw)
In-Reply-To: <20170731233712.12087-5-sthemmin@microsoft.com>
On Mon, 31 Jul 2017 16:37:12 -0700
Stephen Hemminger <stephen@networkplumber.org> wrote:
> The setup of MSI with Hyper-V host was sleeping with locks held.
> This error is reported when doing SR-IOV hotplug with kernel built with lockdep.
>
> BUG: sleeping function called from invalid context at kernel/sched/completion.c:93
> in_atomic(): 1, irqs_disabled(): 1, pid: 1405, name: ip
> 3 locks held by ip/1405:
> #0: (rtnl_mutex){+.+.+.}, at: [<ffffffff976b10bb>] rtnetlink_rcv+0x1b/0x40
> #1: (&desc->request_mutex){+.+...}, at: [<ffffffff970ddd33>] __setup_irq+0xb3/0x720
> #2: (&irq_desc_lock_class){-.-...}, at: [<ffffffff970ddd65>] __setup_irq+0xe5/0x720
> irq event stamp: 3476
> hardirqs last enabled at (3475): [<ffffffff971b3005>] get_page_from_freelist+0x225/0xc90
> hardirqs last disabled at (3476): [<ffffffff978024e7>] _raw_spin_lock_irqsave+0x27/0x90
> softirqs last enabled at (2446): [<ffffffffc05ef0b0>] ixgbevf_configure+0x380/0x7c0 [ixgbevf]
> softirqs last disabled at (2444): [<ffffffffc05ef08d>] ixgbevf_configure+0x35d/0x7c0 [ixgbevf]
>
> The workaround is to poll for host response instead of blocking on
> completion.
>
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
This patch is not directly network related. It needs to go through PCI.
I will resend the series.
prev parent reply other threads:[~2017-07-31 23:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 23:37 [PATCH net-next 0/4] netvsc: transparent SR-IOV VF support Stephen Hemminger
2017-07-31 23:37 ` [PATCH net-next 1/4] netvsc: transparent VF management Stephen Hemminger
2017-07-31 23:37 ` [PATCH net-next 2/4] netvsc: add documentation Stephen Hemminger
2017-07-31 23:37 ` [PATCH net-next 3/4] netvsc: remove bonding setup script Stephen Hemminger
2017-07-31 23:37 ` [PATCH net-next 4/4] pci-hyperv: do not sleep in compose_msi_msg Stephen Hemminger
2017-07-31 23:40 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170731164038.49bc878a@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=corbet@lwn.net \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).