From: Jon Mason <jdmason@kudzu.us>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: linux-ntb@googlegroups.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, Dave Jiang <dave.jiang@intel.com>,
Allen Hubbe <Allen.Hubbe@emc.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kurt Schwemmer <kurt.schwemmer@microsemi.com>,
Stephen Bates <sbates@raithlin.com>,
Serge Semin <fancer.lancer@gmail.com>
Subject: Re: [PATCH v3 05/16] ntb: ntb_test: ensure the link is up before trying to configure the mws
Date: Tue, 1 Aug 2017 14:16:20 -0400 [thread overview]
Message-ID: <20170801181620.GF4186@kudzu.us> (raw)
In-Reply-To: <46065aa6-0fe8-59d5-63dc-3beb66b69154@deltatee.com>
On Tue, Aug 01, 2017 at 12:09:18PM -0600, Logan Gunthorpe wrote:
>
> On 01/08/17 12:07 PM, Jon Mason wrote:
> > On Tue, Jul 25, 2017 at 02:57:42PM -0600, Logan Gunthorpe wrote:
> >> After the link tests, there is a race on one side of the test for
> >> the link coming up. It's possible, in some cases, for the test script
> >> to write to the 'peer_trans' files before the link has come up.
> >>
> >> To fix this, we simply use the link event file to ensure both sides
> >> see the link as up before continuning.
> >>
> >> Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
> >
> > This looks like a bug fix. Assuming this is the case, I can pull it
> > out, add a "Fixes" line, and add it to my bug fixes branch. Is this
> > the case?
>
> Sure, yup, if you'd like to do that I'm fine with it. Technically, I
> don't think the bug can be triggered until the patches later in the
> series are applied.
Given how trivial it is, I think closing the loop here on this would
be a good thing (and one less patch for your v4).
>
> Thanks,
>
> Logan
>
> --
> You received this message because you are subscribed to the Google Groups "linux-ntb" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-ntb+unsubscribe@googlegroups.com.
> To post to this group, send email to linux-ntb@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/linux-ntb/46065aa6-0fe8-59d5-63dc-3beb66b69154%40deltatee.com.
> For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2017-08-01 18:16 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 20:57 [PATCH v3 00/16] Switchtec NTB Support Logan Gunthorpe
2017-07-25 20:57 ` [PATCH v3 01/16] switchtec: move structure definitions into a common header Logan Gunthorpe
2017-07-31 20:15 ` Bjorn Helgaas
2017-07-31 20:51 ` Logan Gunthorpe
2017-07-31 22:50 ` Bjorn Helgaas
2017-07-25 20:57 ` [PATCH v3 02/16] switchtec: export class symbol for use in upper layer driver Logan Gunthorpe
2017-07-25 20:57 ` [PATCH v3 03/16] switchtec: add NTB hardware register definitions Logan Gunthorpe
2017-07-25 20:57 ` [PATCH v3 04/16] switchtec: add link event notifier callback Logan Gunthorpe
2017-07-25 20:57 ` [PATCH v3 05/16] ntb: ntb_test: ensure the link is up before trying to configure the mws Logan Gunthorpe
2017-08-01 18:07 ` Jon Mason
2017-08-01 18:09 ` Logan Gunthorpe
2017-08-01 18:16 ` Jon Mason [this message]
2017-08-01 18:19 ` Logan Gunthorpe
2017-07-25 20:57 ` [PATCH v3 06/16] ntb: ensure ntb_mw_get_align() is only called when the link is up Logan Gunthorpe
2017-07-31 20:16 ` Bjorn Helgaas
2017-08-01 18:14 ` Jon Mason
2017-08-01 18:17 ` Logan Gunthorpe
2017-08-01 18:28 ` Jon Mason
2017-07-25 20:57 ` [PATCH v3 07/16] ntb: add check and comment for link up to mw_count() and mw_get_align() Logan Gunthorpe
2017-08-01 18:11 ` Jon Mason
2017-07-25 20:57 ` [PATCH v3 08/16] switchtec_ntb: introduce initial NTB driver Logan Gunthorpe
2017-07-31 23:08 ` Dave Jiang
2017-07-25 20:57 ` [PATCH v3 09/16] switchtec_ntb: initialize hardware for memory windows Logan Gunthorpe
2017-07-31 20:25 ` Bjorn Helgaas
2017-08-01 18:55 ` Jon Mason
2017-07-25 20:57 ` [PATCH v3 10/16] switchtec_ntb: initialize hardware for doorbells and messages Logan Gunthorpe
2017-07-31 20:26 ` Bjorn Helgaas
2017-07-25 20:57 ` [PATCH v3 11/16] switchtec_ntb: add skeleton NTB driver Logan Gunthorpe
2017-07-25 20:57 ` [PATCH v3 12/16] switchtec_ntb: add link management Logan Gunthorpe
2017-07-31 20:27 ` Bjorn Helgaas
2017-07-25 20:57 ` [PATCH v3 13/16] switchtec_ntb: implement doorbell registers Logan Gunthorpe
2017-08-01 18:59 ` Jon Mason
2017-07-25 20:57 ` [PATCH v3 14/16] switchtec_ntb: implement scratchpad registers Logan Gunthorpe
2017-08-01 19:10 ` Jon Mason
2017-08-01 22:26 ` Logan Gunthorpe
2017-08-02 13:06 ` Allen Hubbe
2017-08-02 16:32 ` Jon Mason
2017-08-02 17:02 ` Logan Gunthorpe
2017-07-25 20:57 ` [PATCH v3 15/16] switchtec_ntb: add memory window support Logan Gunthorpe
2017-07-25 20:57 ` [PATCH v3 16/16] switchtec_ntb: update switchtec documentation with notes for NTB Logan Gunthorpe
2017-07-26 13:09 ` [PATCH v3 00/16] Switchtec NTB Support Allen Hubbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170801181620.GF4186@kudzu.us \
--to=jdmason@kudzu.us \
--cc=Allen.Hubbe@emc.com \
--cc=bhelgaas@google.com \
--cc=dave.jiang@intel.com \
--cc=fancer.lancer@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kurt.schwemmer@microsemi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
--cc=linux-pci@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=sbates@raithlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).