* [PATCH] PCI: dwc: dra7xx: fix error return code in dra7xx_pcie_probe()
@ 2017-08-09 16:16 Gustavo A. R. Silva
2017-08-10 5:40 ` Kishon Vijay Abraham I
2017-08-22 20:37 ` Bjorn Helgaas
0 siblings, 2 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2017-08-09 16:16 UTC (permalink / raw)
To: Kishon Vijay Abraham I, Bjorn Helgaas
Cc: linux-omap, linux-pci, linux-kernel, Gustavo A. R. Silva
platform_get_irq() returns an error code, but the pci-dra7xx driver
ignores it and always returns -EINVAL. This is not correct and,
prevents -EPROBE_DEFER from being propagated properly.
Print and propagate the return value of platform_get_irq on failure.
This issue was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/pci/dwc/pci-dra7xx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
index f2fc5f4..f58e1b4 100644
--- a/drivers/pci/dwc/pci-dra7xx.c
+++ b/drivers/pci/dwc/pci-dra7xx.c
@@ -616,8 +616,8 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev)
irq = platform_get_irq(pdev, 0);
if (irq < 0) {
- dev_err(dev, "missing IRQ resource\n");
- return -EINVAL;
+ dev_err(dev, "missing IRQ resource: %d\n", irq);
+ return irq;
}
res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ti_conf");
--
2.5.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] PCI: dwc: dra7xx: fix error return code in dra7xx_pcie_probe()
2017-08-09 16:16 [PATCH] PCI: dwc: dra7xx: fix error return code in dra7xx_pcie_probe() Gustavo A. R. Silva
@ 2017-08-10 5:40 ` Kishon Vijay Abraham I
2017-08-22 20:37 ` Bjorn Helgaas
1 sibling, 0 replies; 4+ messages in thread
From: Kishon Vijay Abraham I @ 2017-08-10 5:40 UTC (permalink / raw)
To: Gustavo A. R. Silva, Bjorn Helgaas; +Cc: linux-omap, linux-pci, linux-kernel
On Wednesday 09 August 2017 09:46 PM, Gustavo A. R. Silva wrote:
> platform_get_irq() returns an error code, but the pci-dra7xx driver
> ignores it and always returns -EINVAL. This is not correct and,
> prevents -EPROBE_DEFER from being propagated properly.
>
> Print and propagate the return value of platform_get_irq on failure.
>
> This issue was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
> drivers/pci/dwc/pci-dra7xx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
> index f2fc5f4..f58e1b4 100644
> --- a/drivers/pci/dwc/pci-dra7xx.c
> +++ b/drivers/pci/dwc/pci-dra7xx.c
> @@ -616,8 +616,8 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev)
>
> irq = platform_get_irq(pdev, 0);
> if (irq < 0) {
> - dev_err(dev, "missing IRQ resource\n");
> - return -EINVAL;
> + dev_err(dev, "missing IRQ resource: %d\n", irq);
> + return irq;
> }
>
> res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ti_conf");
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] PCI: dwc: dra7xx: fix error return code in dra7xx_pcie_probe()
2017-08-09 16:16 [PATCH] PCI: dwc: dra7xx: fix error return code in dra7xx_pcie_probe() Gustavo A. R. Silva
2017-08-10 5:40 ` Kishon Vijay Abraham I
@ 2017-08-22 20:37 ` Bjorn Helgaas
2017-08-22 20:39 ` Gustavo A. R. Silva
1 sibling, 1 reply; 4+ messages in thread
From: Bjorn Helgaas @ 2017-08-22 20:37 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Kishon Vijay Abraham I, Bjorn Helgaas, linux-omap, linux-pci,
linux-kernel
On Wed, Aug 09, 2017 at 11:16:03AM -0500, Gustavo A. R. Silva wrote:
> platform_get_irq() returns an error code, but the pci-dra7xx driver
> ignores it and always returns -EINVAL. This is not correct and,
> prevents -EPROBE_DEFER from being propagated properly.
>
> Print and propagate the return value of platform_get_irq on failure.
>
> This issue was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Applied with Kishon's ack to pci/host-dra7xx for v4.14, thanks!
> ---
> drivers/pci/dwc/pci-dra7xx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
> index f2fc5f4..f58e1b4 100644
> --- a/drivers/pci/dwc/pci-dra7xx.c
> +++ b/drivers/pci/dwc/pci-dra7xx.c
> @@ -616,8 +616,8 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev)
>
> irq = platform_get_irq(pdev, 0);
> if (irq < 0) {
> - dev_err(dev, "missing IRQ resource\n");
> - return -EINVAL;
> + dev_err(dev, "missing IRQ resource: %d\n", irq);
> + return irq;
> }
>
> res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ti_conf");
> --
> 2.5.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] PCI: dwc: dra7xx: fix error return code in dra7xx_pcie_probe()
2017-08-22 20:37 ` Bjorn Helgaas
@ 2017-08-22 20:39 ` Gustavo A. R. Silva
0 siblings, 0 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2017-08-22 20:39 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: Kishon Vijay Abraham I, Bjorn Helgaas, linux-omap, linux-pci,
linux-kernel
Hi Bjorn,
On 08/22/2017 03:37 PM, Bjorn Helgaas wrote:
> On Wed, Aug 09, 2017 at 11:16:03AM -0500, Gustavo A. R. Silva wrote:
>> platform_get_irq() returns an error code, but the pci-dra7xx driver
>> ignores it and always returns -EINVAL. This is not correct and,
>> prevents -EPROBE_DEFER from being propagated properly.
>>
>> Print and propagate the return value of platform_get_irq on failure.
>>
>> This issue was detected with the help of Coccinelle.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> Applied with Kishon's ack to pci/host-dra7xx for v4.14, thanks!
>
Glad to help. :)
>> ---
>> drivers/pci/dwc/pci-dra7xx.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
>> index f2fc5f4..f58e1b4 100644
>> --- a/drivers/pci/dwc/pci-dra7xx.c
>> +++ b/drivers/pci/dwc/pci-dra7xx.c
>> @@ -616,8 +616,8 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev)
>>
>> irq = platform_get_irq(pdev, 0);
>> if (irq < 0) {
>> - dev_err(dev, "missing IRQ resource\n");
>> - return -EINVAL;
>> + dev_err(dev, "missing IRQ resource: %d\n", irq);
>> + return irq;
>> }
>>
>> res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ti_conf");
>> --
>> 2.5.0
>>
--
Gustavo A. R. Silva
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-08-22 20:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-09 16:16 [PATCH] PCI: dwc: dra7xx: fix error return code in dra7xx_pcie_probe() Gustavo A. R. Silva
2017-08-10 5:40 ` Kishon Vijay Abraham I
2017-08-22 20:37 ` Bjorn Helgaas
2017-08-22 20:39 ` Gustavo A. R. Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).