From: Christoph Hellwig <hch@infradead.org>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-scsi@vger.kernel.org, bhumirks@gmail.com,
kernel-janitors@vger.kernel.org,
MPT-FusionLinux.pdl@broadcom.com, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH 0/6] constify pci_error_handlers structures
Date: Sun, 13 Aug 2017 07:37:50 -0700 [thread overview]
Message-ID: <20170813143750.GB407@infradead.org> (raw)
In-Reply-To: <alpine.DEB.2.20.1708121349080.2001@hadrien>
On Sat, Aug 12, 2017 at 01:51:21PM +0200, Julia Lawall wrote:
> Another issue arises in the files drivers/infiniband/hw/hfi1/pcie.c and
> drivers/infiniband/hw/qib/qib_pcie.c, where the pci_error_handlers
> structure is defined in one file and used in another file. The structure
> definition references various functions that are static in the same file.
> Should I try to move those functions to the file containing the pci_driver
> structure? Or leave the functions where they are and remove the static
> annotation?
I'd just leave them as-is and remove the static for now.
prev parent reply other threads:[~2017-08-13 14:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1502516674-8918-1-git-send-email-Julia.Lawall@lip6.fr>
2017-08-12 7:44 ` [PATCH 0/6] constify pci_error_handlers structures Christoph Hellwig
2017-08-12 7:52 ` Julia Lawall
2017-08-12 7:56 ` Christoph Hellwig
2017-08-12 8:00 ` Julia Lawall
2017-08-12 11:51 ` Julia Lawall
2017-08-13 14:37 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170813143750.GB407@infradead.org \
--to=hch@infradead.org \
--cc=MPT-FusionLinux.pdl@broadcom.com \
--cc=bhumirks@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).