From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=YMQt=7Y=davemloft.net=davem@kernel.org>
Return-Path: <SRS0=YMQt=7Y=davemloft.net=davem@kernel.org>
Date: Tue, 22 Aug 2017 09:45:57 -0700 (PDT)
Message-Id: <20170822.094557.1690177202348153731.davem@davemloft.net>
To: mroos@linux.ee
Cc: hch@lst.de, helgaas@kernel.org, sparclinux@vger.kernel.org,
 linux-pci@vger.kernel.org, qla2xxx-upstream@qlogic.com,
 linux-kernel@vger.kernel.org
Subject: Re: 4.13.0-rc4 sparc64: can't allocate MSI-X affinity masks for 2
 vectors
From: David Miller <davem@davemloft.net>
In-Reply-To: <alpine.LRH.2.20.1708221932490.23061@math.ut.ee>
References: <20170822063505.GA6721@lst.de>
	<20170822.093139.473720171751670244.davem@davemloft.net>
	<alpine.LRH.2.20.1708221932490.23061@math.ut.ee>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
List-ID: <linux-pci.vger.kernel.org>

From: Meelis Roos <mroos@linux.ee>
Date: Tue, 22 Aug 2017 19:33:55 +0300 (EEST)

>> > On Mon, Aug 21, 2017 at 01:35:49PM -0700, David Miller wrote:
>> >> I ask because the commit log message indicates that this failure is
>> >> not expected to ever happen on SMP.
>> > 
>> > I fear my commit message (but not the code) might be wrong.
>> > irq_create_affinity_masks can return NULL any time we don't have any
>> > affinity masks.  I've already had a discussion about this elsewhere
>> > with Bjorn, and I suspect we need to kill the warning or move it
>> > to irq_create_affinity_masks only for genuine failure cases.
>> 
>> This is a rather large machine with 64 or more cpus and several NUMA
>> nodes.  Why wouldn't there be any affinity masks available?
> 
> T5120 with 1 slot and 32 threads total. I have not configured any NUM on 
> it is there any reason for that?

Ok 32 cpus and 1 NUMA node, my bad :-)