From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=EnMX=7Y=lst.de=hch@kernel.org>
Return-Path: <SRS0=EnMX=7Y=lst.de=hch@kernel.org>
Date: Tue, 22 Aug 2017 08:35:05 +0200
From: Christoph Hellwig <hch@lst.de>
To: David Miller <davem@davemloft.net>
Cc: mroos@linux.ee, hch@lst.de, helgaas@kernel.org,
	sparclinux@vger.kernel.org, linux-pci@vger.kernel.org,
	qla2xxx-upstream@qlogic.com, linux-kernel@vger.kernel.org
Subject: Re: 4.13.0-rc4 sparc64: can't allocate MSI-X affinity masks for 2
	vectors
Message-ID: <20170822063505.GA6721@lst.de>
References: <20170821.112747.1532639515902173100.davem@davemloft.net> <20170821183458.GA23205@lst.de> <alpine.LRH.2.20.1708212209280.31611@math.ut.ee> <20170821.133549.1817020810110297960.davem@davemloft.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
In-Reply-To: <20170821.133549.1817020810110297960.davem@davemloft.net>
List-ID: <linux-pci.vger.kernel.org>

On Mon, Aug 21, 2017 at 01:35:49PM -0700, David Miller wrote:
> I ask because the commit log message indicates that this failure is
> not expected to ever happen on SMP.

I fear my commit message (but not the code) might be wrong.
irq_create_affinity_masks can return NULL any time we don't have any
affinity masks.  I've already had a discussion about this elsewhere
with Bjorn, and I suspect we need to kill the warning or move it
to irq_create_affinity_masks only for genuine failure cases.

> 
> We really need to root cause this.
---end quoted text---