* Re: [PATCH] misc: pci_endpoint_test: make boolean no_msi static
2017-08-23 9:47 [PATCH] misc: pci_endpoint_test: make boolean no_msi static Colin King
@ 2017-08-28 15:04 ` Greg Kroah-Hartman
2017-08-29 6:31 ` Kishon Vijay Abraham I
2017-08-29 21:04 ` Bjorn Helgaas
2 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2017-08-28 15:04 UTC (permalink / raw)
To: Colin King
Cc: Arnd Bergmann, Kishon Vijay Abraham I, linux-pci, kernel-janitors,
linux-kernel
On Wed, Aug 23, 2017 at 10:47:52AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The boolean no_msi is local to the source and does not need to be in
> global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'no_msi' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/misc/pci_endpoint_test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c
> index 1f64d943794d..deb203026496 100644
> --- a/drivers/misc/pci_endpoint_test.c
> +++ b/drivers/misc/pci_endpoint_test.c
> @@ -73,7 +73,7 @@ static DEFINE_IDA(pci_endpoint_test_ida);
> #define to_endpoint_test(priv) container_of((priv), struct pci_endpoint_test, \
> miscdev)
>
> -bool no_msi;
> +static bool no_msi;
> module_param(no_msi, bool, 0444);
> MODULE_PARM_DESC(no_msi, "Disable MSI interrupt in pci_endpoint_test");
This doesn't apply to my tree at all :(
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] misc: pci_endpoint_test: make boolean no_msi static
2017-08-23 9:47 [PATCH] misc: pci_endpoint_test: make boolean no_msi static Colin King
2017-08-28 15:04 ` Greg Kroah-Hartman
@ 2017-08-29 6:31 ` Kishon Vijay Abraham I
2017-08-29 21:04 ` Bjorn Helgaas
2 siblings, 0 replies; 4+ messages in thread
From: Kishon Vijay Abraham I @ 2017-08-29 6:31 UTC (permalink / raw)
To: Colin King, Arnd Bergmann, Greg Kroah-Hartman, linux-pci,
Bjorn Helgaas
Cc: kernel-janitors, linux-kernel
Hi Bjorn,
On Wednesday 23 August 2017 03:17 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The boolean no_msi is local to the source and does not need to be in
> global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'no_msi' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Can you pick this one also?
Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
Thanks
Kishon
> ---
> drivers/misc/pci_endpoint_test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c
> index 1f64d943794d..deb203026496 100644
> --- a/drivers/misc/pci_endpoint_test.c
> +++ b/drivers/misc/pci_endpoint_test.c
> @@ -73,7 +73,7 @@ static DEFINE_IDA(pci_endpoint_test_ida);
> #define to_endpoint_test(priv) container_of((priv), struct pci_endpoint_test, \
> miscdev)
>
> -bool no_msi;
> +static bool no_msi;
> module_param(no_msi, bool, 0444);
> MODULE_PARM_DESC(no_msi, "Disable MSI interrupt in pci_endpoint_test");
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] misc: pci_endpoint_test: make boolean no_msi static
2017-08-23 9:47 [PATCH] misc: pci_endpoint_test: make boolean no_msi static Colin King
2017-08-28 15:04 ` Greg Kroah-Hartman
2017-08-29 6:31 ` Kishon Vijay Abraham I
@ 2017-08-29 21:04 ` Bjorn Helgaas
2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Helgaas @ 2017-08-29 21:04 UTC (permalink / raw)
To: Colin King
Cc: Arnd Bergmann, Greg Kroah-Hartman, Kishon Vijay Abraham I,
linux-pci, kernel-janitors, linux-kernel
On Wed, Aug 23, 2017 at 10:47:52AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The boolean no_msi is local to the source and does not need to be in
> global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'no_msi' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Folded into the original patch, thanks!
> ---
> drivers/misc/pci_endpoint_test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c
> index 1f64d943794d..deb203026496 100644
> --- a/drivers/misc/pci_endpoint_test.c
> +++ b/drivers/misc/pci_endpoint_test.c
> @@ -73,7 +73,7 @@ static DEFINE_IDA(pci_endpoint_test_ida);
> #define to_endpoint_test(priv) container_of((priv), struct pci_endpoint_test, \
> miscdev)
>
> -bool no_msi;
> +static bool no_msi;
> module_param(no_msi, bool, 0444);
> MODULE_PARM_DESC(no_msi, "Disable MSI interrupt in pci_endpoint_test");
>
> --
> 2.14.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread