linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Keith Busch <keith.busch@intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	"Derrick, Jonathan" <jonathan.derrick@intel.com>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] vmd: Remove IRQ affinity
Date: Wed, 30 Aug 2017 17:50:02 -0400	[thread overview]
Message-ID: <20170830215002.GB17331@localhost.localdomain> (raw)
In-Reply-To: <20170830214139.GY8154@bhelgaas-glaptop.roam.corp.google.com>

On Wed, Aug 30, 2017 at 04:41:39PM -0500, Bjorn Helgaas wrote:
> I added some breadcrumbs to the changelog about this connection
> between affinity and limiting the number of IRQs.  Did I get this
> right?
> 
> This is on pci/host-vmd for v4.14.

Awesome, sounds good to me! 
 
> commit be85af02e1b00d49cd678d8f2ea6f391bdbaca19
> Author: Keith Busch <keith.busch@intel.com>
> Date:   Wed Aug 30 12:15:04 2017 -0400
> 
>     PCI: vmd: Remove IRQ affinity so we can allocate more IRQs
>     
>     VMD hardware has to share its vectors among child devices in its PCI
>     domain so we should allocate as many as possible rather than just ones
>     that can be affinitized.
>     
>     pci_alloc_irq_vectors_affinity() limits the number of affinitized IRQs to
>     the number of present CPUs (see irq_calc_affinity_vectors()).  But we'd
>     prefer to have more vectors, even if they aren't distributed across the
>     CPUs, so use pci_alloc_irq_vectors() instead.
>     
>     Reported-by: Brad Goodman <Bradley.Goodman@dell.com>
>     Signed-off-by: Keith Busch <keith.busch@intel.com>
>     [bhelgaas: add irq_calc_affinity_vectors() reference to changelog]
>     Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

      reply	other threads:[~2017-08-30 21:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-30 16:15 [PATCH] vmd: Remove IRQ affinity Keith Busch
2017-08-30 16:40 ` Bjorn Helgaas
2017-08-30 20:23   ` Keith Busch
2017-08-30 21:41     ` Bjorn Helgaas
2017-08-30 21:50       ` Keith Busch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170830215002.GB17331@localhost.localdomain \
    --to=keith.busch@intel.com \
    --cc=bhelgaas@google.com \
    --cc=hch@lst.de \
    --cc=helgaas@kernel.org \
    --cc=jonathan.derrick@intel.com \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).