From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "Marek Behún" <marek.behun@nic.cz>,
linux-pci@vger.kernel.org,
"Thomas Petazzoni" <thomas.petazzoni@free-electrons.com>
Subject: Re: aardvark pci controller ath9k request_irq fail
Date: Fri, 22 Sep 2017 14:44:01 +0100 [thread overview]
Message-ID: <20170922134401.GA5207@red-moon> (raw)
In-Reply-To: <20170922133515.GA12546@bhelgaas-glaptop.roam.corp.google.com>
On Fri, Sep 22, 2017 at 08:35:15AM -0500, Bjorn Helgaas wrote:
> [+cc Thomas (aardvark maintainer), Lorenzo]
>
> On Fri, Sep 22, 2017 at 01:24:44PM +0200, Marek Behún wrote:
> > Hello,
> > we are developing a new board based on Marvell Armada 3720.
> > While testing the PCI-e slot, I have enountered this problem:
> >
> > - lspci always correctly prints information about the PCIe card in the
> > slot
> > - when a ath9k card is in the slot, ath9k fails to initialize with
> > ath9k 0000:00:00.0: request_irq failed
> >
> > The irq number passed to the request_irq function is from the irq
> > member of struct pci_dev:
> > request_irq(pdev->irq, ath_isr, IRQF_SHARED, "ath9k", sc);
> >
> > this number (pdev->irq) is 255
> >
> > The request_irq function fails in request_threaded_irq on line:
> > desc = irq_to_desc(irq);
> > (desc is NULL and thus -EINVAL is returned.)
> >
> > - what is strange is that another card, Intel Centrino Ultimate-N 6300
> > with iwlwifi works.
> >
> > - another card (ath10k driver) also does not work.
> >
> > Is this a problem with the pci-aardvark driver for the Aardvark
> > controller?
>
> What kernel version are you using? Has any kernel version worked
> correctly? There have been significant IRQ mapping changes in the
> last couple releases.
>
> dev->irq should be assigned in pci_assign_irq(). Can you turn on the
> debug there (and maybe add more) and collect the complete dmesg log?
It is very likely this will fix it:
https://patchwork.ozlabs.org/patch/811432/
Apologies to you and Thomas again - I went through a number of changes
and mechanically missed pci-aardvark.
Thanks,
Lorenzo
next prev parent reply other threads:[~2017-09-22 13:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 11:24 aardvark pci controller ath9k request_irq fail Marek Behún
2017-09-22 13:35 ` Bjorn Helgaas
2017-09-22 13:44 ` Lorenzo Pieralisi [this message]
2017-09-25 8:47 ` Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170922134401.GA5207@red-moon \
--to=lorenzo.pieralisi@arm.com \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=marek.behun@nic.cz \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox