From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f67.google.com ([74.125.82.67]:35766 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752396AbdJLOke (ORCPT ); Thu, 12 Oct 2017 10:40:34 -0400 Received: by mail-wm0-f67.google.com with SMTP id b189so4106766wmd.2 for ; Thu, 12 Oct 2017 07:40:33 -0700 (PDT) Date: Thu, 12 Oct 2017 16:40:32 +0200 From: Jiri Pirko To: Roopa Prabhu Cc: Steve Lin , "netdev@vger.kernel.org" , Jiri Pirko , "davem@davemloft.net" , michael.chan@broadcom.com, linux-pci@vger.kernel.org, "John W. Linville" , gospo@broadcom.com Subject: Re: [RFC 0/3] Adding config get/set to devlink Message-ID: <20171012144032.GG14672@nanopsycho> References: <1507815262-33294-1-git-send-email-steven.lin1@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-pci-owner@vger.kernel.org List-ID: Thu, Oct 12, 2017 at 04:35:10PM CEST, roopa@cumulusnetworks.com wrote: >On Thu, Oct 12, 2017 at 6:34 AM, Steve Lin wrote: >> Adds a devlink command for getting & setting device configuration >> parameters, and enumerates a bunch of those parameters as devlink >> attributes. Also introduces an attribute that can be set by a >> driver to indicate that the config change doesn't take effect >> until the next restart (as in the case of the bnxt driver changes >> in this patchset, for which all the configuration changes affect NVM >> only, and aren't loaded until the next restart.) >> >> bnxt driver patches make use of these new devlink cmds/attributes. >> >> Steve Lin (3): >> devlink: Add config parameter get/set operations >> bnxt: Move generic devlink code to new file >> bnxt: Add devlink support for config get/set >> > >Is the goal here to move all ethtool operations to devlink (I saw some >attrs related to speed etc). ?. >We do need to move ethtool attrs to netlink and devlink is a good >place (and of-course leave the current ethtool api around for backward >compatibility). We need to make sure we are not moving things to devlink which don't belong there. All options that use "netdev" as a handle should go into rtnetlink instead.