From: Christoph Hellwig <hch@lst.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Dongdong Liu <liudongdong3@huawei.com>,
Charles Chenxin <charles.chenxin@huawei.com>,
linuxarm@huawei.com, Christoph Hellwig <hch@lst.de>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v5 2/3] PCI/portdrv: Remove excessive comments
Date: Fri, 20 Oct 2017 09:07:31 +0200 [thread overview]
Message-ID: <20171020070731.GD11101@lst.de> (raw)
In-Reply-To: <20171019230115.17806.52138.stgit@bhelgaas-glaptop.roam.corp.google.com>
On Thu, Oct 19, 2017 at 06:01:15PM -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> Remove some wordy and repetitive comments so we can see the code better.
> The register field #defines should be enough of a hook to find relevant
> descriptions in the spec. No functional change.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Of course my comments were actually useful ;-)
Looks fine, and fit the style in the rest of the kernel:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2017-10-20 7:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 23:01 [PATCH v5 0/3] PCI/portdrv: Fix MSI/MSI-X bug for PCIe port service drivers Bjorn Helgaas
2017-10-19 23:01 ` [PATCH v5 1/3] PCI/portdrv: Add #defines for AER and DPC Interrupt Message Number masks Bjorn Helgaas
2017-10-20 7:06 ` Christoph Hellwig
2017-10-19 23:01 ` [PATCH v5 2/3] PCI/portdrv: Remove excessive comments Bjorn Helgaas
2017-10-20 7:07 ` Christoph Hellwig [this message]
2017-10-20 13:31 ` Bjorn Helgaas
2017-10-20 13:37 ` Christoph Hellwig
2017-10-19 23:01 ` [PATCH v5 3/3] PCI/portdrv: Compute MSI/MSI-X IRQ vectors after final allocation Bjorn Helgaas
2017-10-20 7:15 ` Christoph Hellwig
2017-10-20 13:36 ` Bjorn Helgaas
2017-10-20 8:20 ` [PATCH v5 0/3] PCI/portdrv: Fix MSI/MSI-X bug for PCIe port service drivers Dongdong Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171020070731.GD11101@lst.de \
--to=hch@lst.de \
--cc=charles.chenxin@huawei.com \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liudongdong3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).