From: Shawn Guo <shawnguo@kernel.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Jianguo Sun <sunjianguo1@huawei.com>,
Jiancheng Xue <xuejiancheng@hisilicon.com>,
Rob Herring <robh+dt@kernel.org>,
linux-pci <linux-pci@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Shawn Guo <shawn.guo@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] PCI: hisi: add PCIe driver support for HiSilicon STB SoCs
Date: Mon, 23 Oct 2017 14:32:25 +0800 [thread overview]
Message-ID: <20171023063224.GI8700@dragon> (raw)
In-Reply-To: <CAKv+Gu9rY-UuVLGBUoVJqbqMR9Gz1Pcw37W4gnfMPmGAdDE=_A@mail.gmail.com>
Hi Ard,
On Sun, Oct 22, 2017 at 10:36:47AM +0100, Ard Biesheuvel wrote:
> > +Example:
> > + pcie@f9860000 {
> > + compatible = "hisilicon,hi3798cv200-pcie";
> > + reg = <0xf9860000 0x1000>,
> > + <0xf0000000 0x2000>,
> > + <0xf2000000 0x01000000>;
> > + reg-names = "control", "rc-dbi", "config";
> > + #address-cells = <3>;
> > + #size-cells = <2>;
> > + device_type = "pci";
> > + bus-range = <0 15>;
> > + num-lanes = <1>;
> > + ranges=<0x81000000 0 0 0xf4000000 0 0x00010000
> > + 0x82000000 0 0xf3000000 0xf3000000 0 0x01000000>;
> > + interrupts = <GIC_SPI 128 IRQ_TYPE_LEVEL_HIGH>;
> > + interrupt-names = "msi";
> > + #interrupt-cells = <1>;
> > + interrupt-map-mask = <0 0 0 7>;
> > + interrupt-map = <0 0 0 1 &gic GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>;
>
> I know this is just the example, but this looks wrong to me: this only
> covers INTA, so any multi-function devices that rely on legacy
> interrupts (such as Nvidia GFX cards with HDMI audio device that are
> blacklisted for MSI support) will fail to work. What I /think/ you
> need is:
>
> interrupt-map-mask = <0 0 0 0>;
> interrupt-map = <0 0 0 0 &gic GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>;
I really appreciate the comment. Yes, all 4 legacy interrupts should be
mapped to this IRQ. I will get it fixed. Thanks again.
Shawn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2017-10-23 6:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-15 5:06 [PATCH] PCI: hisi: add PCIe driver support for HiSilicon STB SoCs Shawn Guo
2017-10-20 22:52 ` Bjorn Helgaas
2017-10-23 3:04 ` Shawn Guo
2017-10-22 9:36 ` Ard Biesheuvel
2017-10-23 6:32 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171023063224.GI8700@dragon \
--to=shawnguo@kernel.org \
--cc=ard.biesheuvel@linaro.org \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=sunjianguo1@huawei.com \
--cc=xuejiancheng@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).