[Patch] export irq_set_msi_desc

[Patch] export irq_set_msi_desc

[subrahmanya l]

[-- Attachment #1: Type: text/plain, Size: 543 bytes --]

Few of the PCIe driver compilation fails with undefined symbol
"irq_set_msi_desc".
This patch is to export it.

-- 
Mobiveil INC., CONFIDENTIALITY NOTICE: This e-mail message, including any 
attachments, is for the sole use of the intended recipient(s) and may 
contain proprietary confidential or privileged information or otherwise be 
protected by law. Any unauthorized review, use, disclosure or distribution 
is prohibited. If you are not the intended recipient, please notify the 
sender and destroy all copies and the original message.

[-- Attachment #2: 0001-linux-driver-fix.patch --]
[-- Type: application/octet-stream, Size: 500 bytes --]


Signed-off-by: Subrahmanya Lingappa <l.subrahmanya@mobiveil.co.in>

diff -Naur kernel-source/kernel/irq/chip.c kernel-source.mod/kernel/irq/chip.c
--- kernel-source/kernel/irq/chip.c	2017-10-17 04:42:12.027684844 -0400
+++ kernel-source.mod/kernel/irq/chip.c	2017-10-17 04:43:44.904198138 -0400
@@ -137,6 +137,7 @@
 	return irq_set_msi_desc_off(irq, 0, entry);
 }
 
+EXPORT_SYMBOL(irq_set_msi_desc);
 /**
  *	irq_set_chip_data - set irq chip data for an irq
  *	@irq:	Interrupt number

Re: [Patch] export irq_set_msi_desc

[Christoph Hellwig]

On Wed, Nov 08, 2017 at 09:54:09PM +0530, subrahmanya l wrote:
> Few of the PCIe driver compilation fails with undefined symbol
> "irq_set_msi_desc".
> This patch is to export it.

Which ones?  Also please add an explanation of why you thing it should
be exported and Cc the irq code maintainers.

Re: [Patch] export irq_set_msi_desc

[subrahmanya l]

Christoph,

Xilinx MSI driver uses it.

file path: https://github.com/Xilinx/linux-xlnx/blob/master/drivers/pci/host/pcie-xilinx.c#L286

I used the same driver as reference to write another Rootport driver
which needs it too.

Thanks,
~subbu

On Wed, Nov 8, 2017 at 10:54 PM, Christoph Hellwig <hch@infradead.org> wrote:
>
> On Wed, Nov 08, 2017 at 09:54:09PM +0530, subrahmanya l wrote:
> > Few of the PCIe driver compilation fails with undefined symbol
> > "irq_set_msi_desc".
> > This patch is to export it.
>
> Which ones?  Also please add an explanation of why you thing it should
> be exported and Cc the irq code maintainers.

-- 
Mobiveil INC., CONFIDENTIALITY NOTICE: This e-mail message, including any 
attachments, is for the sole use of the intended recipient(s) and may 
contain proprietary confidential or privileged information or otherwise be 
protected by law. Any unauthorized review, use, disclosure or distribution 
is prohibited. If you are not the intended recipient, please notify the 
sender and destroy all copies and the original message.

Re: [Patch] export irq_set_msi_desc

[Marc Zyngier]

On Thu, 9 Nov 2017 10:42:06 +0530
subrahmanya l <l.subrahmanya@mobiveil.co.in> wrote:

> Christoph,
> 
> Xilinx MSI driver uses it.
> 
> file path: https://github.com/Xilinx/linux-xlnx/blob/master/drivers/pci/host/pcie-xilinx.c#L286
> 
> I used the same driver as reference to write another Rootport driver
> which needs it too.

You shouldn't need this at all. The driver you are looking at is using
a deprecated API, and you should implement the MSI part of your driver
using the generic MSI layer which takes care of this and shouldn't
require exporting this function.

There is a number of drivers in the tree that have been converted to
generic MSI, such as pcie-tango.c for example.

Thanks,

	M.
-- 
Without deviation from the norm, progress is not possible.

Re: [Patch] export irq_set_msi_desc

[Subrahmanya Lingappa]

Marc,
I have dropped this patch off from the patch series.
I will look into generic handling of MSI too.

Thanks.


On Wed, Nov 22, 2017 at 1:32 PM, Marc Zyngier <marc.zyngier@arm.com> wrote:
> On Thu, 9 Nov 2017 10:42:06 +0530
> subrahmanya l <l.subrahmanya@mobiveil.co.in> wrote:
>
>> Christoph,
>>
>> Xilinx MSI driver uses it.
>>
>> file path: https://github.com/Xilinx/linux-xlnx/blob/master/drivers/pci/host/pcie-xilinx.c#L286
>>
>> I used the same driver as reference to write another Rootport driver
>> which needs it too.
>
> You shouldn't need this at all. The driver you are looking at is using
> a deprecated API, and you should implement the MSI part of your driver
> using the generic MSI layer which takes care of this and shouldn't
> require exporting this function.
>
> There is a number of drivers in the tree that have been converted to
> generic MSI, such as pcie-tango.c for example.
>
> Thanks,
>
>         M.
> --
> Without deviation from the norm, progress is not possible.