From: Simon Horman <horms@verge.net.au>
To: Biju Das <biju.das@bp.renesas.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Magnus Damm <magnus.damm@gmail.com>,
Chris Paterson <chris.paterson2@renesas.com>,
Fabrizio Castro <fabrizio.castro@bp.renesas.com>,
linux-pci@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: PCI: rcar: Add device tree support for r8a7743
Date: Wed, 15 Nov 2017 05:29:01 -0800 [thread overview]
Message-ID: <20171115132901.eoxy6hhons7eed4l@verge.net.au> (raw)
In-Reply-To: <1510653543-53770-1-git-send-email-biju.das@bp.renesas.com>
On Tue, Nov 14, 2017 at 09:59:03AM +0000, Biju Das wrote:
> Add support for r8a7743. The Renesas RZ/G1M(R8A7743)PCIe controller
> is identical to the R-Car Gen2 family.
>
> No driver change is needed due to the fallback compatible value
> "renesas,pcie-rcar-gen2".
> Adding the SoC-specific compatible values here has three purposes:
> 1. Document which SoCs have this hardware module,
> 2. Allow checkpatch to validate compatible values.
> 3. Allow the driver to support SoC specific implementations in future
> as necessary.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> v1-->v2
> Corrected RZ-G1 to RZ/G1.
>
> Documentation/devicetree/bindings/pci/rcar-pci.txt | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/rcar-pci.txt b/Documentation/devicetree/bindings/pci/rcar-pci.txt
> index 76ba3a6..1fb614e 100644
> --- a/Documentation/devicetree/bindings/pci/rcar-pci.txt
> +++ b/Documentation/devicetree/bindings/pci/rcar-pci.txt
> @@ -1,13 +1,15 @@
> * Renesas R-Car PCIe interface
>
> Required properties:
> -compatible: "renesas,pcie-r8a7779" for the R8A7779 SoC;
> +compatible: "renesas,pcie-r8a7743" for the R8A7743 SoC;
> + "renesas,pcie-r8a7779" for the R8A7779 SoC;
> "renesas,pcie-r8a7790" for the R8A7790 SoC;
> "renesas,pcie-r8a7791" for the R8A7791 SoC;
> "renesas,pcie-r8a7793" for the R8A7793 SoC;
> "renesas,pcie-r8a7795" for the R8A7795 SoC;
> "renesas,pcie-r8a7796" for the R8A7796 SoC;
> - "renesas,pcie-rcar-gen2" for a generic R-Car Gen2 compatible device.
> + "renesas,pcie-rcar-gen2" for a generic R-Car Gen2 or
> + RZ/G1 compatible device.
> "renesas,pcie-rcar-gen3" for a generic R-Car Gen3 compatible device.
>
> When compatible with the generic version, nodes must list the
> --
> 1.9.1
>
next prev parent reply other threads:[~2017-11-15 13:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 9:59 [PATCH v2] dt-bindings: PCI: rcar: Add device tree support for r8a7743 Biju Das
2017-11-15 13:29 ` Simon Horman [this message]
2017-12-11 13:30 ` Biju Das
2018-01-10 23:27 ` Bjorn Helgaas
2018-03-06 16:41 ` Fabrizio Castro
2018-03-06 17:37 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171115132901.eoxy6hhons7eed4l@verge.net.au \
--to=horms@verge.net.au \
--cc=bhelgaas@google.com \
--cc=biju.das@bp.renesas.com \
--cc=chris.paterson2@renesas.com \
--cc=fabrizio.castro@bp.renesas.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).