From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Date: Mon, 11 Dec 2017 11:29:55 +0100 From: Johan Hovold To: Murali Karicheri , Lorenzo Pieralisi , Bjorn Helgaas Subject: Re: [PATCH v2] PCI: keystone: fix interrupt-controller-node lookup Message-ID: <20171211102955.GK5672@localhost> References: <20171117133831.1300-1-johan@kernel.org> MIME-Version: 1.0 In-Reply-To: <20171117133831.1300-1-johan@kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pci@vger.kernel.org, stable , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Johan Hovold Content-Type: text/plain; charset="us-ascii" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+bjorn=helgaas.com@lists.infradead.org List-ID: On Fri, Nov 17, 2017 at 02:38:31PM +0100, Johan Hovold wrote: > Fix child-node lookup during initialisation which was using the wrong > OF-helper and ended up searching the whole device tree depth-first > starting at the parent rather than just matching on its children. > > To make things worse, the parent pci node could end up being prematurely > freed as of_find_node_by_name() drops a reference to its first argument. > Any matching child interrupt-controller node was also leaked. > > Fixes: 0c4ffcfe1fbc ("PCI: keystone: Add TI Keystone PCIe driver") > Cc: stable # 3.18 > Acked-by: Murali Karicheri > Acked-by: Lorenzo Pieralisi > Signed-off-by: Johan Hovold > --- > > v2 > - amend commit message and mention explicitly that of_find_node_by_name() > drops a reference to the start node > - add Murali's and Lorenzo's acks This one hasn't shown up in linux-next, so sending a reminder to make sure it doesn't fall between the cracks. Thanks, Johan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel