Re: [PATCH v4 0/3] Fix find_first_zero_bit() usage

Kishon Vijay Abraham I
2017-12-14T11:26:05Z

Hi Lorenzo,

On Thursday 14 December 2017 04:21 PM, Lorenzo Pieralisi wrote:
> Hi Kishon,
>
> On Tue, Dec 12, 2017 at 03:16:31PM +0100, Niklas Cassel wrote:
>> find_first_zero_bit()'s parameter 'size' is defined in bits,
>> not in bytes.
>>
>> Calling find_first_zero_bit() with the wrong size unit
>> will lead to insidious bugs.
>>
>> Fix all uses of find_first_zero_bit() called with
>> sizeof() as size argument in drivers/pci.
>>
>> Also had to fix broken error handling in pci_epc_epf_link()
>> in order to do proper error handling for find_first_zero_bit().
>>
>> Niklas Cassel (3):
>> PCI: designware-ep: Fix find_first_zero_bit() usage
>> PCI: endpoint: Fix error handling in pci_epc_epf_link()
>> PCI: endpoint: Fix find_first_zero_bit() usage
>>
>> drivers/pci/dwc/pcie-designware-ep.c | 34 ++++++++++++++++++++++++++--------
>> drivers/pci/dwc/pcie-designware.h | 8 ++++++--
>> drivers/pci/endpoint/pci-ep-cfs.c | 13 ++++++++-----
>> 3 files changed, 40 insertions(+), 15 deletions(-)
>
> I would need your ACK asap to queue this series.

Sorry for the delay. I had a comment on the 2nd patch.

Thanks
Kishon