Re: [PATCH v4 0/3] Fix find_first_zero_bit() usage

Bjorn Helgaas
2017-12-13T21:59:30Z

On Tue, Dec 12, 2017 at 03:16:31PM +0100, Niklas Cassel wrote:
> find_first_zero_bit()'s parameter 'size' is defined in bits,
> not in bytes.
>
> Calling find_first_zero_bit() with the wrong size unit
> will lead to insidious bugs.
>
> Fix all uses of find_first_zero_bit() called with
> sizeof() as size argument in drivers/pci.
>
> Also had to fix broken error handling in pci_epc_epf_link()
> in order to do proper error handling for find_first_zero_bit().
>
> Niklas Cassel (3):
> PCI: designware-ep: Fix find_first_zero_bit() usage
> PCI: endpoint: Fix error handling in pci_epc_epf_link()
> PCI: endpoint: Fix find_first_zero_bit() usage
>
> drivers/pci/dwc/pcie-designware-ep.c | 34 ++++++++++++++++++++++++++--------
> drivers/pci/dwc/pcie-designware.h | 8 ++++++--
> drivers/pci/endpoint/pci-ep-cfs.c | 13 ++++++++-----
> 3 files changed, 40 insertions(+), 15 deletions(-)

In the interest of making forward progress, I applied these to
for-linus for v4.15.

The issues apparently have been there since v4.12-rc1, but I guess
this is proposed for for-linus because (a) it fixes insidious bugs
and (b) the endpoint framework is relatively little-used yet so
low-risk. Right?

Bjorn