From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Max Gurtovoy <maxg@mellanox.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: pci driver loads right after unload
Date: Wed, 3 Jan 2018 12:18:34 +0100 [thread overview]
Message-ID: <20180103111834.GA5412@kroah.com> (raw)
In-Reply-To: <fb4bb470-c30e-c173-3267-99e283f79e02@mellanox.com>
On Wed, Jan 03, 2018 at 12:50:05PM +0200, Max Gurtovoy wrote:
> Hi Greg/Bjorn,
>
> On 1/2/2018 9:27 PM, Greg Kroah-Hartman wrote:
> > On Tue, Jan 02, 2018 at 01:00:03PM -0600, Bjorn Helgaas wrote:
> > > [+cc Greg, linux-kernel]
> > >
> > > Hi Max,
> > >
> > > Thanks for the report!
> > >
> > > On Tue, Jan 02, 2018 at 01:50:23AM +0200, Max Gurtovoy wrote:
> > > > hi all,
> > > > I encountered a strange phenomena using 2 different pci drivers
> > > > (nvme and mlx5_core) since 4.15-rc1:
> > > > when I try to unload the modules using "modprobe -r" cmd it calls
> > > > the .probe function right after calling the .remove function and the
> > > > module is not realy unloaded.
> > > > I think there is some race condition because when I added a
> > > > msleep(1000) after "pci_unregister_driver(&nvme_driver);" (in the
> > > > nvme module testing, it also worked in the mlx5_core), the issue
> > > > seems to dissapear.
> > >
> > > You say "since 4.15-rc1". Does that mean it's a regression? If so,
> > > what's the most recent kernel that does not have this problem? Worst
> > > case, you could bisect to find where it broke.
> > >
> > > I don't see anything obvious in the drivers/pci changes between v4.14
> > > and v4.15-rc1. Module loading and driver binding is mostly driven by
> > > the driver core and udev. Maybe you could learn something with
> > > "udevadm monitor" or by turning on the some of the debug in
> > > lib/kobject_uevent.c?
> >
> >
> > This should be resolved in 4.15-rc6, there was a regression in -rc1 in
> > this area when dealing with uevents over netlink.
> >
> > Max, can you test -rc6 to verify if this is really fixed or not?
>
> I've tested -rc6 and the issue doesn't repro.
> I'll continue monitoring this scenario in -rc7.
> Can you point to the commit that fixes the issue ? and I'll test the kernel
> with/without this patch.
9b3fa47d4a76 ("kobject: fix suppressing modalias in uevents delivered over netlink")
prev parent reply other threads:[~2018-01-03 11:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-01 23:50 pci driver loads right after unload Max Gurtovoy
2018-01-02 19:00 ` Bjorn Helgaas
2018-01-02 19:27 ` Greg Kroah-Hartman
2018-01-03 10:50 ` Max Gurtovoy
2018-01-03 11:18 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180103111834.GA5412@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=maxg@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).