Re: Regression: NULL pointer dereference caused by iproc_pcie_map_dma_ranges

[Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>]

On Tue, Jan 02, 2018 at 11:00:43PM +0100, Rafał Miłecki wrote:
> On 2 January 2018 at 19:44, Ray Jui <ray.jui@broadcom.com> wrote:
> > Can you please give the following patch a try to see if that fixes the
> > issue? Thanks.
> 
> It does, thank you!
> 
> 
> > From f91de124bc8fb5645d7dbbfd68a9a68617955749 Mon Sep 17 00:00:00 2001
> > From: Ray Jui <ray.jui@broadcom.com>
> > Date: Tue, 2 Jan 2018 10:36:03 -0800
> > Subject: [PATCH] PCI: iproc: Fix NULL pointer dereference for BCMA
> >
> > With the inbound DMA mapping supported added, the iProc PCIe driver
> > parses DT property "dma-ranges" through call to
> > "of_pci_dma_range_parser_init". In the case of BCMA, this results in a
> > NULL pointer deference due to a missing of_node.
> >
> > Fix this by adding a guard in pcie-iproc-platform.c to only enable the
> > inbound DMA mapping logic when DT property "dma-ranges" is present
> >
> > fixes: dd9d4e7498de3 ("PCI: iproc: Add inbound DMA mapping support")
> > Signed-off-by: Ray Jui <ray.jui@broadcom.com>
> 
> Please add:
> Tested-by: Rafał Miłecki <rafal@milecki.pl>
> Cc: stable@vger.kernel.org # 4.10+

FYI, if you want the patch to be applied please post it on linux-pci
in a separate thread.

Thanks,
Lorenzo